Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: add tunefastdeviceclass: true for all ssd disk #2963

Merged

Conversation

parth-gr
Copy link
Member

@parth-gr parth-gr commented Jan 10, 2025

with exandstorage ux-backend handler we will be
adding ssd disk always,
So by default make the deviceSet spec, deviceType: ssd

@parth-gr
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@parth-gr: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@parth-gr
Copy link
Member Author

@parth-gr parth-gr changed the title osd: ass tunefastdeviceclass: true for all ssd disk osd: add tunefastdeviceclass: true for all ssd disk Jan 10, 2025
with exandstorage ux-backend handler we will be
ading ssd disk always,
So by default make the deviceSet spec, `deviceType: ssd`

Signed-off-by: parth-gr <[email protected]>
@parth-gr parth-gr force-pushed the tunefastdeviceclass branch from 8309c4b to 291653a Compare January 10, 2025 12:22
Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2025
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000, parth-gr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 0fbee25 into red-hat-storage:main Jan 10, 2025
11 checks passed
@openshift-cherrypick-robot

@parth-gr: new pull request created: #2964

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants