Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: added generic error notification component #120

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

audrium
Copy link
Member

@audrium audrium commented Sep 14, 2020

addresses #118

Copy link
Member

@diegodelemos diegodelemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! a couple of minor comments and two that need some feedback :)

reana-ui/src/actions.js Outdated Show resolved Hide resolved
reana-ui/src/actions.js Outdated Show resolved Hide resolved
reana-ui/src/actions.js Outdated Show resolved Hide resolved
reana-ui/src/components/Notification.js Outdated Show resolved Hide resolved
reana-ui/src/reducers.js Show resolved Hide resolved
reana-ui/src/components/Notification.js Outdated Show resolved Hide resolved
reana-ui/src/components/Notification.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants