Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: better error pages #99

Closed
mvidalgarcia opened this issue May 25, 2020 · 3 comments · Fixed by #235
Closed

ui: better error pages #99

mvidalgarcia opened this issue May 25, 2020 · 3 comments · Fixed by #235
Assignees
@audrium @mvidalgarcia
Labels
ui/general

Comments

@mvidalgarcia
Copy link
Member

Introduce better error pages for different HTTP status responses.
For now a tiny component <Error /> was introduced. It permits to customize title and message.
image

A good place for inspiration.
@mvidalgarcia
Copy link
Member Author

Evaluate if a sign out link in these pages makes sense. At the moment a revoked user cannot sign out and try to sign in with a different account.

@audrium
Copy link
Member

audrium commented Sep 15, 2020

We should also think about unifying the error handling across the application. Some disscusion happened in this PR: #120 (comment) with a suggestion to use a similar approach to one described here.

@audrium audrium mentioned this issue Sep 15, 2020
Merged
@mvidalgarcia
Copy link
Member Author

mvidalgarcia commented Nov 24, 2020 •
edited
Loading

When accessing reana.cern.ch/foo, one gets a blank page. No errors HTTP occur involved as this is not foreseen.

image

We should redirect to an error page. This can be done via React routes. We probably need a new Route that matches all (*?) and is evaluated the last one, to redirect to a 404 page.

Related: https://stackoverflow.com/a/37491381/3506161

@mvidalgarcia mvidalgarcia self-assigned this Mar 7, 2022
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Mar 10, 2022
@mvidalgarcia
router: redirect to 404 not found page
50fd232 
- redirect to `/404` when no path match is found
- add new `NotFound` page

closes reanahub#99
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Mar 10, 2022
@mvidalgarcia
router: redirect to 404 not found page
5b44bec 
- redirect to `/404` when no path match is found
- add new `NotFound` page

closes reanahub#99
@mvidalgarcia mvidalgarcia mentioned this issue Mar 10, 2022
Merged
@audrium audrium self-assigned this Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@audrium audrium

@mvidalgarcia mvidalgarcia

Labels
ui/general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

router: redirect to 404 not found page mvidalgarcia/reana-ui
2 participants
@audrium @mvidalgarcia