Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): avoid rethrowing errors when development=true #1003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(node): avoid rethrowing errors when development=true #1003

wants to merge 1 commit into from

Commits on May 30, 2024

  1. fix(node): avoid rethrowing errors when development=true 

    When development=true, the SDK re-throws in a floating promise, leaving
no way for the caller to catch it. This crashes the node process.

In lieu of proposing an error handling or logging API to use, this
PR/commit is more to point out the problem than suggest a long-term
solve.
    @mothershipper
    mothershipper committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a0a1e94 View commit details
    Browse the repository at this point in the history