fix(node): avoid rethrowing errors when development=true #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When development=true, the SDK re-throws in a floating promise, leaving no way for the caller to catch it. This crashes the node process. In lieu of proposing an error handling or logging API to use, this PR/commit is more to point out the problem than suggest a long-term solve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When development=true, the SDK re-throws in a floating promise, leaving no way for the caller to catch it. This crashes the node process.
In lieu of proposing an error handling or logging API to use, this PR/commit is more to point out the problem than suggest a long-term solve.
See #1001 for context