Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chain modal v2 #1806

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: chain modal v2 #1806

wants to merge 10 commits into from

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Feb 26, 2024

Changes

  • Now you can choose any chains even if your wallet is not connected.
  • Works with siwe.
  • During connection process, it automatically selects the chain you picked earlier. Or the one you set as your default initialChain instead.
  • If you've set initialChain, the option to change networks will be hidden to prevent accidental switches.
  • The current chain will show up only even if you have one chain unless you set chainStatus to none

Screen recordings / screenshots

chain-modal-v2.mov

What to test

  1. Checkbox the chainModalOnConnect in the example app
  2. Try opening the chain modal and switch through your desired chain
  3. While connecting your wallet, confirm it connects to the chain you chose.
  4. Set initialChain and check if the chain button is no longer visible.
  5. Make sure everything works well with siwe. Test this connecting to your wallet first and then you should see chain button dissapear. This prevents users from switching chains with their connected wallet when they are not signed in yet.

@magiziz magiziz requested a review from a team as a code owner February 26, 2024 11:37
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 0:54am
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 0:54am

Co-authored-by: Lukas Lücke <[email protected]>
@oxSaturn
Copy link

oxSaturn commented Apr 1, 2024

Hi, can we expect this feature soon? Been waiting for this a while.

@magiziz
Copy link
Contributor Author

magiziz commented Apr 1, 2024

@0xartcro Apologies for this taking a while, we'll try to aim launching this as soon as possible. Please bear with us 🙏

@magiziz magiziz changed the title feat: chain modal (v2) feat: chain modal v2 Apr 8, 2024
@t0rbik
Copy link

t0rbik commented May 10, 2024

Hey guys! Do you have any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Network switcher is hidden until a wallet is connected
4 participants