Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass openChainModal even if connectionStatus is not connected #1927

Closed
wants to merge 1 commit into from

Conversation

hungdoansy
Copy link
Contributor

@hungdoansy hungdoansy commented Apr 15, 2024

Some DEXes often support multiple chains. Users tend to play around without connecting to the websites.

With the current value of ModalContext, it's not possible for users to switch chains without connecting wallets.

@hungdoansy hungdoansy requested a review from a team as a code owner April 15, 2024 07:11
Copy link

vercel bot commented Apr 15, 2024

@hungdoansy is attempting to deploy a commit to the rainbowdotme Team on Vercel.

A member of the Team first needs to authorize it.

@hungdoansy
Copy link
Contributor Author

Hi @magiziz, can you please review this PR?

@magiziz
Copy link
Contributor

magiziz commented Apr 15, 2024

@hungdoansy Can you explain more why this change is needed ? Ideally we would want to open the chain modal after user has authenticated / connected their wallet, but lmk your what you think.

@hungdoansy
Copy link
Contributor Author

@hungdoansy Can you explain more why this change is needed ? Ideally we would want to open the chain modal after user has authenticated / connected their wallet, but lmk your what you think.

I believe that people should be able to change the network to play with the webapp even tho they haven't connected yet.
Why?
Some people don't have wallet or they just don't want to connect to strange websites. We shouldn't prevent them playing around with the webapp.

How'd you think?

@0xartcro
Copy link
Contributor

@hungdoansy Can you explain more why this change is needed ? Ideally we would want to open the chain modal after user has authenticated / connected their wallet, but lmk your what you think.

I believe that people should be able to change the network to play with the webapp even tho they haven't connected yet. Why? Some people don't have wallet or they just don't want to connect to strange websites. We shouldn't prevent them playing around with the webapp.

How'd you think?

#1806 Should fix that I believe

@magiziz
Copy link
Contributor

magiziz commented Apr 16, 2024

@hungdoansy Can you explain more why this change is needed ? Ideally we would want to open the chain modal after user has authenticated / connected their wallet, but lmk your what you think.

I believe that people should be able to change the network to play with the webapp even tho they haven't connected yet. Why? Some people don't have wallet or they just don't want to connect to strange websites. We shouldn't prevent them playing around with the webapp.

How'd you think?

Right. That change will also cause users to switch chains without having their wallet connected which would result to unexpected behavior and like @0xartcro mentioned the PR #1806 should fix this behaviour.

@hungdoansy
Copy link
Contributor Author

Thanks @magiziz @0xartcro for letting me know. Just took a look at the preview link. It's exactly what I needed. I'll close this PR now.

@hungdoansy hungdoansy closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants