New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: chain modal v2 #1806
Open
magiziz
wants to merge
10
commits into
main
Choose a base branch
from
@mago/chain-modal-feat
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: chain modal v2 #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lukasluecke
reviewed
Feb 26, 2024
Co-authored-by: Lukas Lücke <[email protected]>
1 task
Hi, can we expect this feature soon? Been waiting for this a while. |
@0xartcro Apologies for this taking a while, we'll try to aim launching this as soon as possible. Please bear with us 🙏 |
1 task
Hey guys! Do you have any progress on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
siwe
.initialChain
instead.initialChain
, the option to change networks will be hidden to prevent accidental switches.chainStatus
tonone
Screen recordings / screenshots
chain-modal-v2.mov
What to test
chainModalOnConnect
in the example appinitialChain
and check if the chain button is no longer visible.siwe
. Test this connecting to your wallet first and then you should see chain button dissapear. This prevents users from switching chains with their connected wallet when they are not signed in yet.