refactor migrate util into persistOptions util #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-schrammel
commented
Apr 26, 2024
Comment on lines
+110
to
+115
| if (migrations && migrations.length !== storeVersion) { | ||
| throw new Error(` | ||
| !! Review the migrations !! | ||
| (store name: ${persistOptions.name}) | ||
| `); | ||
| } |
There was a problem hiding this comment.
this is the cool part
Closed
estebanmino
approved these changes
Apr 29, 2024
|
Here's the packed extension for this build: |
|
we also need this change #1520 (comment) to remove the "degen" label here |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
magiziz
pushed a commit
that referenced
this pull request
Apr 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
replaces the util
migratewith apersistOptionsso we have more control over the persist options and can make sure it matches the current version with the number of migrationsthis could probably be integrated into
createStorebut I couldn't make the types work right rnScreen recordings / screenshots
What to test