update migrations #1520
update migrations #1520
Conversation
|
Here's the packed extension for this build: |
estebanmino
requested review from
greg-schrammel,
DanielSinclair and
derHowie
and removed request for
greg-schrammel
|
Here's the packed extension for this build: |
| m6: (s: E) => F, | ||
| ): R<F>; | ||
| // if you need more migrations, add more overloads here | ||
| <T>(migrations: ((s: any) => any)[]): R<T>; |
There was a problem hiding this comment.
this removes all the type safety 😔😔😔 don't think it's worth it
There was a problem hiding this comment.
is there any other option for this? adding 15+ lines per new migration is not the best either
| @@ -80,7 +80,7 @@ export const chainLabelMap: Record< | |||
| [ChainId.zora]: [ChainNameDisplay[zoraSepolia.id]], | |||
| [ChainId.avalanche]: [ChainNameDisplay[avalancheFuji.id]], | |||
| [ChainId.blast]: [ChainNameDisplay[chainBlastSepolia.id]], | |||
| [ChainId.degen]: [ChainNameDisplay[chainDegen.id]], | |||
| [ChainId.degen]: [], | |||
There was a problem hiding this comment.
should this be removed?
yes this is the expected behavior we can make the util throw if the version and quantity of migrations mismatches |
|
tried an idea here #1523 |
|
closing for #1523 |
Fixes BX-1443
Figma link (if any):
What changed (plus any additional context for devs)
new method
migrateis working fine but we were using it wrongly together with version number for state slicesfor rainbowChains we had version 7, with 6 migrations
migrateapplies the migration functions one by one removing the ones from 0 toversion(.toSliced(0,version)`) so if you were in version 6, all of the migrations would be removed since the migrations were 6, so none of the migrations were being executedwe have to have this in mind for the next time we use this method
I updated
migrateto accept any arbitrary number of elements in an array param since it was annoying to add a new interface for each element in the arrayScreen recordings / screenshots
What to test