Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) Add Support of Primitives V2 and ISA circuits for GroverOptimizer and QRAO #622

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

(WIP) Add Support of Primitives V2 and ISA circuits for GroverOptimizer and QRAO #622

wants to merge 5 commits into from

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented May 29, 2024 •
edited
Loading

Summary

WIP

This PR updates GroverOptimizer and QRAO to support PrimitivesV2 + ISA circuits.

Need to update SamplingVQE in qiskit-algorithms so that MinimumEigenOptimizer supports PrimitivesV2 and ISA circuits too.

Details and comments

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9286789815

Details

  • 42 of 49 (85.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 92.799%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_optimization/algorithms/qrao/magic_rounding.py 17 19 89.47%
qiskit_optimization/algorithms/qrao/encoding_commutation_verifier.py 14 19 73.68%
Totals Coverage Status
Change from base Build 9128549330: -0.2%
Covered Lines: 4472
Relevant Lines: 4819
💛 - Coveralls

@t-imamichi t-imamichi mentioned this pull request May 30, 2024
Draft
@t-imamichi t-imamichi changed the title (WIP) Add Support of Primitives V2 and ISA circuits (WIP) Add Support of Primitives V2 and ISA circuits for GroverOptimizer and QRAO May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner stefan-woerner will be requested when the pull request is marked ready for review stefan-woerner is a code owner

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm woodsp-ibm will be requested when the pull request is marked ready for review woodsp-ibm is a code owner

@TolisChal TolisChal Awaiting requested review from TolisChal TolisChal will be requested when the pull request is marked ready for review TolisChal is a code owner

@thkleinert thkleinert Awaiting requested review from thkleinert thkleinert will be requested when the pull request is marked ready for review thkleinert is a code owner

@Dniskk Dniskk Awaiting requested review from Dniskk Dniskk will be requested when the pull request is marked ready for review Dniskk is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-imamichi @coveralls