-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PoC) Add Primitives V2 + ISA circuit support #623
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 9296831983Details
💛 - Coveralls |
As it was mentioned, the changes rely on the modifications in qiskit_algorithm that you add in compat/. We may have to wait for a similar fix in qiskit_algorithm before we implement this PoC. |
As a FYI I'll link this PR where the parts of qiskit.algorithms (inlcude optimizers) that were in use by ML have been copied over into ML, with algorithms going unsupported.: https://github.com/qiskit-community/qiskit-algorithms?tab=readme-ov-file#qiskit-algorithms
|
Summary
Based on #622
This PR is just a PoC for discussions. Not intended to be merged yet.
This PR copies the following necessary modules from qiskit-algorithms to
qiskti-optimization.compat
module by modifying them to support Primitives V2 + ISA circuits.This allows us to use qiskit-optimization with SamplerV2 and a real device as follows.
MinimumEigenOptimizer
output
grover optimizer
output
Details and comments
This PR is still WIP. It is missing the following items at least.