Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fix for gdb/libpython.py docs #118438

Merged
merged 2 commits into from
May 2, 2024
Merged

Small fix for gdb/libpython.py docs #118438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2191b84
Small fix for gdb/libpython.py docs
Andrej730 Apr 30, 2024
5480f86
update gdb/libpython.PyLongObjectPtr docs
Andrej730 May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions Tools/gdb/libpython.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def proxyval(self, visited):

Derived classes will override this.

For example, a PyIntObject* with ob_ival 42 in the inferior process
For example, a PyLongObjectPtr* with long_value 42 in the inferior process
should result in an int(42) in this process.

visited: a set of all gdb.Value pyobject pointers already visited
Expand Down Expand Up @@ -867,7 +867,7 @@ class PyLongObjectPtr(PyObjectPtr):

def proxyval(self, visited):
'''
Python's Include/longobjrep.h has this declaration:
Python's Include/longinterpr.h has this declaration:

typedef struct _PyLongValue {
uintptr_t lv_tag; /* Number of digits, sign and flags */
Expand All @@ -876,14 +876,18 @@ def proxyval(self, visited):

struct _longobject {
PyObject_HEAD
_PyLongValue long_value;
_PyLongValue long_value;
};

with this description:
The absolute value of a number is equal to
SUM(for i=0 through abs(ob_size)-1) ob_digit[i] * 2**(SHIFT*i)
Negative numbers are represented with ob_size < 0;
zero is represented by ob_size == 0.
SUM(for i=0 through ndigits-1) ob_digit[i] * 2**(PyLong_SHIFT*i)
The sign of the value is stored in the lower 2 bits of lv_tag.
- 0: Positive
- 1: Zero
- 2: Negative
The third lowest bit of lv_tag is reserved for an immortality flag, but is
not currently used.

where SHIFT can be either:
#define PyLong_SHIFT 30
Expand Down
Loading