Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for gdb/libpython.py docs #118438

Merged
merged 2 commits into from May 2, 2024
Merged

Small fix for gdb/libpython.py docs #118438

merged 2 commits into from May 2, 2024

Conversation

Andrej730
Copy link
Contributor

Just accidentally noticed that it was mentioning PyIntObject * type which is deprecated - replaced it with PyLongObject *. Also replaced "ob_ival" with "long_value" - similar field that's used in PyLongObjectPtr.proxyval.

Just accidentally noticed that it was mentioning `PyIntObject *` type which is deprecated - replaced it with `PyLongObject *`. Also replaced "ob_ival" with "long_value" - similar field that's used in `PyLongObjectPtr.proxyval`.
Copy link

cpython-cla-bot bot commented Apr 30, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Apr 30, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Eclips4
Copy link
Member

Eclips4 commented Apr 30, 2024

We also should update this line:

Python's Include/longobjrep.h has this declaration:

Include/longobjrep.h -> Include/longinterpr.h

@Andrej730 Andrej730 requested a review from Eclips4 May 1, 2024 16:48
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me! Thanks.

@encukou encukou enabled auto-merge (squash) May 2, 2024 08:36
@encukou encukou merged commit f8e088d into python:main May 2, 2024
34 checks passed
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.x has failed when building commit f8e088d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1368/builds/894) and take a look at the build logs.
  4. Check if the failure is related to this commit (f8e088d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1368/builds/894

Failed tests:

  • test_free_threading

Failed subtests:

  • test_free_reference - test.test_concurrent_futures.test_thread_pool.ThreadPoolExecutorTest.test_free_reference

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 131, in test_free_reference
    self.assertIsNone(wr())
    ~~~~~~~~~~~~~~~~~^^^^^^
AssertionError: <test.test_concurrent_futures.executor.MyObject object at 0x20002080100> is not None

@Eclips4
Copy link
Member

Eclips4 commented May 2, 2024

Buildbot failure unrelated; probably related to #118444

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants