Update pointcloud.py #265
Open
Update pointcloud.py #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update lets you run the pointcloud.py that downloads and visualizes the bunnies before any ICP. Signed-off-by: Shashank Dammalapati <[email protected]>
|
Please re run the test in circleci, there is something wrong but not in your part. Re run the test can fix it. |
XyC0212
reviewed
Jul 25, 2023
| import torch, os | ||
| import matplotlib.pyplot as plt | ||
| from matplotlib.lines import Line2D | ||
| from torchvision.datasets.utils import download_and_extract_archive | ||
| import argparse | ||
| import os |
There was a problem hiding this comment.
os has been import in line 8
| import torch, os | ||
| import matplotlib.pyplot as plt | ||
| from matplotlib.lines import Line2D | ||
| from torchvision.datasets.utils import download_and_extract_archive | ||
| import argparse |
There was a problem hiding this comment.
Follow the pyramid coding style mentioned in https://github.com/pypose/pypose/wiki/Developer-Guideline
wang-chen
requested changes
Jul 26, 2023
Comment on lines
+1
to
+7
| ''' | ||
| Simple Test | ||
|
|
||
| python pointcloud.py --algorithm Bunnies_before_ICP --dataroot data --save save --show | ||
|
|
||
| ''' | ||
|
|
There was a problem hiding this comment.
Our current style is to provide this in readme.md of the examples, respectively.
| # Load bunny | ||
|
|
||
| source, target, gt_tf = load_bunny(root=args.dataroot, device=args.device) | ||
| pointcloud_plot(args.algorithm, source, target, save=args.save, show=args.show) |
There was a problem hiding this comment.
this doesn't run the algorithm yet, thus the default arg args.algorithm is not appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update lets you run the pointcloud.py that downloads and visualizes the bunnies before any ICP.