refactor: remove data fetcher, use static types where possible #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/refactor/static
branch
from
5471f01
to
1de7f4d
Compare
Merged
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/refactor/static
branch
from
1de7f4d
to
fe33310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the DataFetcher with simple functions and direct dict access to preserve static types. This allows #128 to self validate most of the operations internally. This was how I found the
entrypoints->entry-pointsbug in #128 that I fixed before merging.Will refactor into a file since this would be nicer for organisation, since all these functions are grouped into "accessing the pyproject dict" (and aren't public, which is reflected in
__all__, but better to fully hide, IMO).