Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shuffleable traits for all shuffle routines #1402

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andyleiserson
Copy link
Collaborator

This uses the Shuffleable trait (originally added for the semi-honest sharded shuffle) in the base shuffle and malicious shuffle code. Doing so simplifies the trait bounds on many of the shuffle routines.

The bounds on ShuffleShare here are similar to but different from BooleanArray. I avoid assuming Copy, which probably doesn't matter much for the things we shuffle currently, but makes the implementation more extensible to shuffling larger things.

There are also a few other changes. Most notably, I adopt the one-side PRSS generation that was added #1187. I also eliminate some clones and make some other small adjustments / simplifications.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 98.71383% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (21e954d) to head (0fbde18).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/protocol/ipa_prf/shuffle/mod.rs 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
- Coverage   93.63%   93.51%   -0.12%     
==========================================
  Files         223      223              
  Lines       37949    38450     +501     
==========================================
+ Hits        35532    35955     +423     
- Misses       2417     2495      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eriktaubeneck eriktaubeneck mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant