Use Shuffleable trait for shuffle inputs #1397
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #1402. It implements the
Shuffleable
trait forAttributionOutputs
andOPRFIPAInputRow
and removes the glue functions around shuffle. The amount of code is about the same, but this avoids additional copies of the input/output that were allocated in the glue functions.If reviewing before #1402 is merged, you probably want to set a commit filter to exclude the first two commits.