Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shuffleable trait for shuffle inputs #1397

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

andyleiserson
Copy link
Collaborator

@andyleiserson andyleiserson commented Nov 1, 2024

This is on top of #1402. It implements the Shuffleable trait for AttributionOutputs and OPRFIPAInputRow and removes the glue functions around shuffle. The amount of code is about the same, but this avoids additional copies of the input/output that were allocated in the glue functions.

If reviewing before #1402 is merged, you probably want to set a commit filter to exclude the first two commits.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 98.29787% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.46%. Comparing base (21e954d) to head (135d0fa).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/ff/boolean_array.rs 92.30% 4 Missing ⚠️
ipa-core/src/protocol/ipa_prf/shuffle/mod.rs 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   93.63%   93.46%   -0.17%     
==========================================
  Files         223      223              
  Lines       37949    38320     +371     
==========================================
+ Hits        35532    35815     +283     
- Misses       2417     2505      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyleiserson andyleiserson changed the title [DRAFT] Shuffleable trait changes [DRAFT] Use Shuffleable trait for shuffle inputs Nov 4, 2024
@andyleiserson andyleiserson changed the title [DRAFT] Use Shuffleable trait for shuffle inputs Use Shuffleable trait for shuffle inputs Nov 6, 2024
@andyleiserson andyleiserson marked this pull request as ready for review November 6, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant