Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to swc_core 0.91.0 #29

Closed
wants to merge 1 commit into from
Closed

Upgrade to swc_core 0.91.0 #29

wants to merge 1 commit into from
+546 −389

Conversation

JonathanUsername
Copy link

As requested in #27 I try to address the required upgrade.

  • Upgrade to 0.91.0
  • Need to upgrade the rust-toolchain version to latest stable to handle proc_macro_span
  • Convert now missing PatOrExpr to AssignTarget (this is NAIVE, I am trusting tests here)
  • convert tests to test_inline as per other upgrades in swc

@JonathanUsername JonathanUsername changed the title Upgrade to 0.91.0 Upgrade to swc_core 0.91.0 Apr 26, 2024
@AndrewIngram
Copy link
Contributor

0.91 might be a hop too far in one go, as the broader ecosystem is currently on 0.90

I've tried this out but with 0.90 instead, and it seems to work with Next 14.2

@JonathanUsername
Copy link
Author

You can probably leave the serde changes too, I don't think they're necessary

@AndrewIngram AndrewIngram mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanUsername @AndrewIngram