Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swc_core to 0.90.37 #30

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

AndrewIngram
Copy link
Contributor

@AndrewIngram AndrewIngram commented Apr 26, 2024

Resolves #27

Should make it compatible with Next 14.2.

I've tested this by building the new wasm file and overriding the one in node_modules for debug_label. Not sure what more is needed.

(Based on #29 from @JonathanUsername)

Should make it compatible with Next 14.2
@dai-shi
Copy link
Member

dai-shi commented Apr 26, 2024

@Thisen Are you able to review it?

@cenobitedk
Copy link

Hi there! There's a ton of people using Next and Jotai and all are blocked from upgrading Next to anything higher than 14.1.4 if they want to maintain a good developer experience.
It would be awesome if you found some time to review @Thisen 😃🙏

@dai-shi
Copy link
Member

dai-shi commented May 29, 2024

Would anyone volunteer to be a co-maintainer?

@chrisjh
Copy link

chrisjh commented May 29, 2024

@dai-shi I'd be willing to help out as we're blocked on this as well. Admittedly, rust isn't my area of expertise but seems like the surface area is small enough for me to get a handle on it. I really enjoy using Jotai so feels like the least I could do to give back to the project.

@dai-shi
Copy link
Member

dai-shi commented May 30, 2024

@chrisjh Thanks for your help.
I think we need someone who is fairly familiar with Rust and SWC.
For a start, I would like someone to implement a github workflow to automate the publish process. Something like this: pmndrs/jotai#2578
Would you be able to work on it?

@Thisen
Copy link
Collaborator

Thisen commented Jun 11, 2024

This looks super great. I promise I'll get it integrated and released this week. 👍🏼

@Thisen Thisen merged commit 76d140b into pmndrs:main Jun 13, 2024
4 checks passed
@AndrewIngram AndrewIngram deleted the upgrade-to-swc-core-0.90 branch June 14, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade swc_core to ~0.90.x
5 participants