Merge pull request #16 from lucassabreu/master

(fix): exception will never be a int
phpro · Jul 8, 2021 · 46fdf98 · 46fdf98
2 parents af35ef0 + 8c45d35
commit 46fdf98
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/spec/Http/ExceptionApiProblemSpec.php b/spec/Http/ExceptionApiProblemSpec.php
@@ -144,4 +144,17 @@ public function it_should_deal_with_string_exception_codes(): void
             'detail' => $message,
         ]);
     }
+
+    public function it_should_use_code_as_status_code_when_valid_http_status_code_error(): void
+    {
+        $message = 'an honest error';
+        $this->beConstructedWith(new \InvalidArgumentException($message, 400));
+
+        $this->toArray()->shouldBe([
+            'status' => 400,
+            'type' => HttpApiProblem::TYPE_HTTP_RFC,
+            'title' => HttpApiProblem::getTitleForStatusCode(400),
+            'detail' => $message,
+        ]);
+    }
 }
diff --git a/src/Http/ExceptionApiProblem.php b/src/Http/ExceptionApiProblem.php
@@ -18,7 +18,7 @@ public function __construct(Throwable $exception)
     {
         $this->exception = $exception;
         $exceptionCode = $exception->getCode();
-        $statusCode = is_int($exception) && $exceptionCode >= 400 && $exceptionCode <= 599
+        $statusCode = is_int($exceptionCode) && $exceptionCode >= 400 && $exceptionCode <= 599
             ? $exceptionCode
             : 500;