Merge pull request #15 from veewee/non-numeric-error-codes

Return 500 for non numeric exception codes
phpro · May 21, 2021 · af35ef0 · af35ef0
2 parents 33e0764 + f98f521
commit af35ef0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/spec/Http/ExceptionApiProblemSpec.php b/spec/Http/ExceptionApiProblemSpec.php
@@ -129,4 +129,19 @@ public function it_uses_the_class_of_the_exception_when_no_message_exists(): voi
             'detail' => Exception::class,
         ]);
     }
+
+    public function it_should_deal_with_string_exception_codes(): void
+    {
+        $exception = new class($message = 'hell no') extends Exception {
+            protected $code = 'nope';
+        };
+        $this->beConstructedWith($exception);
+
+        $this->toArray()->shouldBe([
+            'status' => 500,
+            'type' => HttpApiProblem::TYPE_HTTP_RFC,
+            'title' => HttpApiProblem::getTitleForStatusCode(500),
+            'detail' => $message,
+        ]);
+    }
 }
diff --git a/src/Http/ExceptionApiProblem.php b/src/Http/ExceptionApiProblem.php
@@ -18,7 +18,7 @@ public function __construct(Throwable $exception)
     {
         $this->exception = $exception;
         $exceptionCode = $exception->getCode();
-        $statusCode = $exceptionCode >= 400 && $exceptionCode <= 599
+        $statusCode = is_int($exception) && $exceptionCode >= 400 && $exceptionCode <= 599
             ? $exceptionCode
             : 500;