[GCP] Fix for private service connect bug

[smcclure20]

Resolves #495

Root issues:

• Some of the original code was just simply wrong (changing request fields after sending the request)
• Google service connections require Global IPs and Global Forwarding rules

Future issues:

• There is a lot of repeated code here - we can probably clean it up
• This and other resources should take advantage of the fact that the orchestrator can now give variable-sized address spaces

[github-actions]

Unit Test Results

323 tests  ±0   323 ✅ ±0   5s ⏱️ +3s
 50 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 96107cf. ± Comparison against base commit 3ac4011.

♻️ This comment has been updated with latest results.

[github-actions]

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

• Your PR branch coverage: 55.1 %
• main branch coverage: 0 %
• diff coverage: 55.1 %

The coverage result does not include the functional test results.

[github-actions]

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

• Your PR branch coverage: 55.1 %
• main branch coverage: 0 %
• diff coverage: 55.1 %

The coverage result does not include the functional test results.

[praveingk]

Looks good!

[github-actions]

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

• Your PR branch coverage: 55.1 %
• main branch coverage: 0 %
• diff coverage: 55.1 %

The coverage result does not include the functional test results.

[github-actions]

For the detailed report, please go to Checks tab, click Build and Test, and then download unit_test_coverage artifact at the bottom of build page.

• Your PR branch coverage: 55.1 %
• main branch coverage: 0 %
• diff coverage: 55.1 %

The coverage result does not include the functional test results.

[divega]

Just a couple of newbie questions.

[divega]

For my education, are these clients functional after calling Close? E.g., do they provide methods to re-open or do they automatically re-establish anything needed for operation if you make any subsequent call?

Otherwise, should we be setting fields to nil explicitly, to allow for a functional client to be populated again via GetOrCreate methods?

Perhaps it's ok if we only use Close when we are shutting down the serice or going to recycle the entire struct?

[divega]

Should we create an issue to track this in more detail, or are we ok with tracking with TODOs?