Feature Flags #508
Open
Feature Flags #508
+317
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah McClure <[email protected]>
Signed-off-by: Sarah McClure <[email protected]>
smcclure20
requested a deployment
to
functional-tests
GitHub Actions
Waiting
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 1e1bf36. |
divega
approved these changes
Jan 23, 2025
| client := paragliderpb.NewCloudPluginClient(conn) | ||
| cloudFlags := ¶gliderpb.PluginFlags{KubernetesClustersEnabled: cfg.FeatureFlags.PluginFlags[c.Name].KubernetesClustersEnabled, | ||
| PrivateEndpointsEnabled: cfg.FeatureFlags.PluginFlags[c.Name].PrivateEndpointsEnabled} | ||
| _, err = client.SetFlags(context.Background(), ¶gliderpb.SetFlagsRequest{Flags: cloudFlags}) |
There was a problem hiding this comment.
missing logging or returning err?
| AttachResourceEnabled bool `yaml:"attachResourceEnabled"` | ||
| } | ||
|
|
||
| type PluginFlags struct { |
There was a problem hiding this comment.
Did you consider having a flat struct containing all feature flags? I think I like the simplicity of it, plus it doesn't prevent use from having a feature flag that both orchestrator and plugins need to reason about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Resolves #506