Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static-html: Clean-up the CSS file a bit #8633

Merged
merged 7 commits into from
May 15, 2024
Merged

static-html: Clean-up the CSS file a bit #8633

merged 7 commits into from
May 15, 2024

Commits on May 15, 2024

  1. chore(static-html): Remove the hover effect from the project tables 

    This line has effect on the project tables only. It highlights a row
using a gray background color. Remove the highlighting, because a
highlighted row does not look nice and to prepare for an upcoming
re-design of the project table. This is simpler if the highlighted state
can be disregarded initially.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 15, 2024
    Configuration menu
    Copy the full SHA
    26cbd95 View commit details
    Browse the repository at this point in the history

  2. refactor(static-html): Style the report label at the top via ID 

    Make it clearer that the styling applies only to a single element
and won't be applied to further similar elements in the future.

While at it, choose a more speaking name which differs a bit more from
the also existing `ort-report-labels` class name.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 15, 2024
    Configuration menu
    Copy the full SHA
    36797d9 View commit details
    Browse the repository at this point in the history

  3. refactor(static-html): Use a more speaking name for ort-report-labels 

    The classes is not just used for styling the `OrtResult.labels`, but
also for styling the VCS info within each project table. So, use a more
generic name which applies to both.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 15, 2024
    Configuration menu
    Copy the full SHA
    4de644a View commit details
    Browse the repository at this point in the history

  4. refactor(static-html): Use more speaking names for two top level tables 

    Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 15, 2024
    Configuration menu
    Copy the full SHA
    91641e7 View commit details
    Browse the repository at this point in the history

  5. refactor(static-html): Remove some unnecessary specialization 

    The classes `ort-report-project-table` and
`ort-report-rule-violation-table` intent to be child classes of
`ort-report-table`. So, all HTML tags which correspond to the child
class also always specify the parent class. Therefore, matching the
parent class is not necessary.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 15, 2024
    Configuration menu
    Copy the full SHA
    84e1645 View commit details
    Browse the repository at this point in the history

  6. refactor(static-html): Drop ort- prefix from class attribute names 

    The prefix does not provide additional value. Remove it to improve the
readability.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 15, 2024
    Configuration menu
    Copy the full SHA
    90fc398 View commit details
    Browse the repository at this point in the history

  7. refactor(static-html): Re-arrange the CSS file 

    Group related styles together and add comments to the resulting
sections. This intends to give a better overview as a basis for
re-designing the project table.

Signed-off-by: Frank Viernau <[email protected]>
    @fviernau
    fviernau committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e514e13 View commit details
    Browse the repository at this point in the history