static-html: Clean-up the CSS file a bit #8633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
static-html-css-cleanup
branch
from
3838cc3
to
779be49
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8633 +/- ##
=========================================
Coverage 67.92% 67.92%
Complexity 1005 1005
=========================================
Files 244 244
Lines 7772 7772
Branches 876 876
=========================================
Hits 5279 5279
Misses 2110 2110
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
static-html-css-cleanup
branch
from
779be49
to
811a177
Compare
sschuberth
requested changes
May 15, 2024
| @@ -63,21 +63,25 @@ | |||
| width: 110px; | |||
| } | |||
|
|
|||
| .ort-report-labels { | |||
| /* | |||
There was a problem hiding this comment.
Commit message: "So, Use" -> "So, use"
| @@ -183,17 +183,17 @@ | |||
| border-right: 1px solid rgba(34, 36, 38, .15); | |||
| } | |||
|
|
|||
| .ort-report-table.ort-report-rule-violation-table tr.ort-resolved { | |||
| .ort-report-rule-violation-table tr.ort-resolved { | |||
There was a problem hiding this comment.
Commit message: In the first sentence, the "specializations" / "spezialize" duplication reads a bit odd, IMO. Can you think of a way to reword? Maybe just say "refers to" instead of "spezialize"? In any case, it should say "specialize".
There was a problem hiding this comment.
I ended up re-wording it to avoid the term "specialize" entirely.
This line has effect on the project tables only. It highlights a row using a gray background color. Remove the highlighting, because a highlighted row does not look nice and to prepare for an upcoming re-design of the project table. This is simpler if the highlighted state can be disregarded initially. Signed-off-by: Frank Viernau <[email protected]>
Make it clearer that the styling applies only to a single element and won't be applied to further similar elements in the future. While at it, choose a more speaking name which differs a bit more from the also existing `ort-report-labels` class name. Signed-off-by: Frank Viernau <[email protected]>
The classes is not just used for styling the `OrtResult.labels`, but also for styling the VCS info within each project table. So, use a more generic name which applies to both. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
The classes `ort-report-project-table` and `ort-report-rule-violation-table` intent to be child classes of `ort-report-table`. So, all HTML tags which correspond to the child class also always specify the parent class. Therefore, matching the parent class is not necessary. Signed-off-by: Frank Viernau <[email protected]>
The prefix does not provide additional value. Remove it to improve the readability. Signed-off-by: Frank Viernau <[email protected]>
Group related styles together and add comments to the resulting sections. This intends to give a better overview as a basis for re-designing the project table. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
static-html-css-cleanup
branch
from
811a177
to
e514e13
Compare
sschuberth
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not intend to arrive at something perfect, but targets a better overview as a preparation
for a re-design of the project table which will involve some further refactoring of CSS structure.
Part of: #7921.