Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libyder: add package #25503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vidplace7
Copy link
Contributor

@vidplace7 vidplace7 commented Dec 5, 2024

Maintainer: me
Compile tested: OpenWRT One master/snapshot

Description:
New package, libyder. See: babelouest/yder

yder is a build dependency for the meshtasticd web interface, currently packaged at the openwrt-meshtastic project.

@@ -2,7 +2,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=libulfius
PKG_VERSION:=2.7.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new version available: 2.7.15

Copy link
Contributor Author

@vidplace7 vidplace7 Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that! I can include a version bump in this PR as well if you'd like. Just didn't want to conflate two changes (since I intend to backport this as well)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be great! :)
I'll appreciate every contribution as I currently have some time restrictions.

@vidplace7 vidplace7 marked this pull request as draft December 6, 2024 00:28
@vidplace7 vidplace7 force-pushed the libyder branch 2 times, most recently from 46cb323 to 4b3e943 Compare December 6, 2024 01:01
@vidplace7 vidplace7 changed the title libyder: add package / optional libulfius bindings libyder: add package, bump ulfius and orcania versions Dec 6, 2024
@utoni
Copy link
Contributor

utoni commented Dec 6, 2024

Hopefully, the OpenWrt guys will agree with changing multiple packages in one PR. 😄

@vidplace7
Copy link
Contributor Author

Hopefully, the OpenWrt guys will agree with changing multiple packages in one PR. 😄

If not I'm happy to split it up. 😅
Testing this again with the new changes before un-marking as Draft 👍

@vidplace7 vidplace7 force-pushed the libyder branch 5 times, most recently from d3a82f5 to 7519d00 Compare December 9, 2024 03:09
@BKPepe
Copy link
Member

BKPepe commented Dec 9, 2024

Hopefully, the OpenWrt guys will agree with changing multiple packages in one PR. 😄

No... :) It's making Git history look bad and if something is wrong, you will revert everything not the faulty package. Treewide changes are possible, but one huge commit updating various packages, its not the way.

@vidplace7 vidplace7 force-pushed the libyder branch 6 times, most recently from 1c386ee to 106086f Compare December 9, 2024 17:02
@vidplace7 vidplace7 changed the title libyder: add package, bump ulfius and orcania versions libyder: add package Dec 9, 2024
@vidplace7
Copy link
Contributor Author

Breaking up my changes into separate PRs and keeping this one focused on adding libyder 👍

@vidplace7 vidplace7 force-pushed the libyder branch 2 times, most recently from 6ac507a to e743bb9 Compare December 9, 2024 18:50
@vidplace7 vidplace7 marked this pull request as ready for review December 9, 2024 18:52
@vidplace7
Copy link
Contributor Author

Depends on PR for liborcania: #25526 in order to install correctly.

libs/libyder/Makefile Outdated Show resolved Hide resolved
@vidplace7 vidplace7 force-pushed the libyder branch 5 times, most recently from 74c5e20 to bef4c82 Compare December 17, 2024 15:47
Signed-off-by: Austin Lane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants