Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Twitter to connect #490

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/feature-request.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Suggest a new feature or improvement for the leaderboard Website
description: 'Do you have an idea or a suggestion and you want to share?'
description: "Do you have an idea or a suggestion and you want to share?"
labels: [feature request]
body:
- type: markdown
Expand All @@ -10,10 +10,10 @@ body:
something related to your suggestion.
- type: textarea
attributes:
label: 'Enter your suggestions in details:'
label: "Enter your suggestions in details:"
placeholder: |
1. What I expected to happen.
2. Your reason (if possible, images or videos are welcome).
3. What I plan to do (Optional but better).
validations:
required: true
required: true
18 changes: 9 additions & 9 deletions .github/ISSUE_TEMPLATE/technical-visual.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: Report a Technical/Visual Issue on the leaderboard Website
description: 'Is something not working as expected? Did you encounter a glitch or a bug with the Website?'
description: "Is something not working as expected? Did you encounter a glitch or a bug with the Website?"
labels: [bug]
body:
- type: markdown
Expand All @@ -11,40 +11,40 @@ body:
for us to fix it when you attach a screenshot as well.
- type: input
attributes:
label: 'URL:'
label: "URL:"
description: The URL of the page you are reporting an issue on.
placeholder: https://contributors.ohc.network/
validations:
required: true
- type: input
attributes:
label: 'Browser Name:'
label: "Browser Name:"
description: What kind of browser are you using?
placeholder: Chrome
validations:
required: true
- type: input
attributes:
label: 'Browser Version:'
label: "Browser Version:"
description: What version of browser are you using?
placeholder: '103.0.5060.134'
placeholder: "103.0.5060.134"
validations:
required: true
- type: input
attributes:
label: 'Operating System:'
label: "Operating System:"
description: What kind of operation system are you using
(Write it in full, with version number)?
placeholder: 'Windows 10, 21H2, 19044.1826'
placeholder: "Windows 10, 21H2, 19044.1826"
validations:
required: true
- type: textarea
attributes:
label: 'How to reproduce the issue:'
label: "How to reproduce the issue:"
placeholder: |
1. What I did.
2. What I expected to happen.
3. What I actually got.
4. If possible, images or videos are welcome.
validations:
required: true
required: true
6 changes: 3 additions & 3 deletions .github/workflows/scraper-dry-run.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
working-directory: scraper

- name: Scrape data from GitHub
run: pnpm start ${{ github.repository_owner }} ../data/github
run: pnpm start ${{ github.repository_owner }} ../data/github
working-directory: scraper
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -48,15 +48,15 @@ jobs:
run: node scripts/generateNewContributors.js
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- uses: actions/upload-artifact@v4
with:
name: output
retention-days: 5
path: |
data
contributors

- name: Get pnpm store directory
shell: bash
run: |
Expand Down
12 changes: 4 additions & 8 deletions .prettierrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@
"semi": true,
"jsxSingleQuote": false,
"arrowParens": "always",
"tailwindFunctions": [
"classNames"
],
"plugins": [
"prettier-plugin-tailwindcss"
],
"endOfLine":"auto"
}
"tailwindFunctions": ["classNames"],
"plugins": ["prettier-plugin-tailwindcss"],
"endOfLine": "auto"
}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,4 +106,4 @@ You will be able to see the user's profile page at `http://localhost:3000/contri
| **NEXT_PUBLIC_PAGE_TITLE** | Will be displayed in page title. | OHC Network Contributors | No |
| **NEXT_PUBLIC_CONTRIBUTORS_INFO** | Will be displayed next to "Our Contributors" section. You can use it to display a note about your contributors. | | Yes |
| **DATA_SOURCE** | Url for data repository | https://github.com/coronasafe/leaderboard-data.git | Yes |
| **NEXT_PUBLIC_FEATURES** | These features will be displayed | Leaderboard,Contributors,Feed,Releases, | Yes |
| **NEXT_PUBLIC_FEATURES** | These features will be displayed | Leaderboard,Contributors,Feed,Releases, | Yes |
63 changes: 42 additions & 21 deletions components/Footer.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
import Image from "next/image";
import { env } from "@/env.mjs";
import { FaYoutube, FaLinkedin, FaGithub, FaEnvelope } from "react-icons/fa";
import {
FaYoutube,
FaLinkedin,
FaGithub,
FaEnvelope,
FaTwitter,
} from "react-icons/fa";
import { ReactNode } from "react";

const SocialLink = ({
Expand Down Expand Up @@ -94,26 +100,41 @@ export default function Footer() {

<FooterSection title="Connect">
<div className="flex space-x-4">
<SocialLink
href={env.NEXT_PUBLIC_YOUTUBE_URL}
icon={FaYoutube}
label="YouTube"
/>
<SocialLink
href={env.NEXT_PUBLIC_LINKEDIN_URL}
icon={FaLinkedin}
label="LinkedIn"
/>
<SocialLink
href={env.NEXT_PUBLIC_GITHUB_URL}
icon={FaGithub}
label="GitHub"
/>
<SocialLink
href={`mailto:${env.NEXT_PUBLIC_CONTACT_EMAIL}`}
icon={FaEnvelope}
label="Email"
/>
{env.NEXT_PUBLIC_TWITTER_URL && (
<SocialLink
href={env.NEXT_PUBLIC_TWITTER_URL}
icon={FaTwitter}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be using the Twitter's X logo instead

label="Twitter"
/>
)}
{env.NEXT_PUBLIC_YOUTUBE_URL && (
<SocialLink
href={env.NEXT_PUBLIC_YOUTUBE_URL}
icon={FaYoutube}
label="YouTube"
/>
)}
{env.NEXT_PUBLIC_LINKEDIN_URL && (
<SocialLink
href={env.NEXT_PUBLIC_LINKEDIN_URL}
icon={FaLinkedin}
label="LinkedIn"
/>
)}
{env.NEXT_PUBLIC_GITHUB_URL && (
<SocialLink
href={env.NEXT_PUBLIC_GITHUB_URL}
icon={FaGithub}
label="GitHub"
/>
)}
{env.NEXT_PUBLIC_CONTACT_EMAIL && (
<SocialLink
href={`mailto:${env.NEXT_PUBLIC_CONTACT_EMAIL}`}
icon={FaEnvelope}
label="Email"
/>
)}
</div>
</FooterSection>
</div>
Expand Down
2 changes: 1 addition & 1 deletion components/discussions/GithubDiscussion.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const GithubDiscussion = ({

return (
<div
className={`group mt-3 flex w-full gap-3 ${minimal ? "lg:w-full" : "lg:w-[75%]"} ${!isProfilePage ? "mt-5" : "lg:w-full"}`}
className={`group mt-3 flex w-full gap-3 ${minimal ? "lg:w-full" : "lg:w-3/4"} ${!isProfilePage ? "mt-5" : "lg:w-full"}`}
>
{/* Left side */}
{!isProfilePage && (
Expand Down
9 changes: 6 additions & 3 deletions env.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export const env = createEnv({
NEXT_PUBLIC_GITHUB_URL: z.string(),
NEXT_PUBLIC_LINKEDIN_URL: z.string(),
NEXT_PUBLIC_YOUTUBE_URL: z.string(),
NEXT_PUBLIC_TWITTER_URL: z.string().optional(), // Add this line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NEXT_PUBLIC_TWITTER_URL: z.string().optional(), // Add this line
NEXT_PUBLIC_TWITTER_URL: z.string().optional(),

NEXT_PUBLIC_CONTACT_EMAIL: z.string(),

// SEO details
Expand All @@ -32,7 +33,7 @@ export const env = createEnv({

NEXT_PUBLIC_FEATURES: z.string(),
NEXT_PUBLIC_DATA_SOURCE: z.string(),
NEXT_PUBLIC_FLAT_REPO_EXPLORER_URL: z.string()
NEXT_PUBLIC_FLAT_REPO_EXPLORER_URL: z.string(),
},
runtimeEnv: {
NEXT_PUBLIC_ORG_NAME: process.env.NEXT_PUBLIC_ORG_NAME,
Expand All @@ -56,10 +57,12 @@ export const env = createEnv({
: process.env.GITHUB_PAT,
NEXT_PUBLIC_FEATURES: process.env.NEXT_PUBLIC_FEATURES,
NEXT_PUBLIC_DATA_SOURCE: process.env.NEXT_PUBLIC_DATA_SOURCE,
NEXT_PUBLIC_FLAT_REPO_EXPLORER_URL: process.env.NEXT_PUBLIC_FLAT_REPO_EXPLORER_URL,
NEXT_PUBLIC_FLAT_REPO_EXPLORER_URL:
process.env.NEXT_PUBLIC_FLAT_REPO_EXPLORER_URL,
NEXT_PUBLIC_GITHUB_URL: process.env.NEXT_PUBLIC_GITHUB_URL,
NEXT_PUBLIC_LINKEDIN_URL: process.env.NEXT_PUBLIC_LINKEDIN_URL,
NEXT_PUBLIC_YOUTUBE_URL: process.env.NEXT_PUBLIC_YOUTUBE_URL,
NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, // Add this line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, // Add this line
NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL,

NEXT_PUBLIC_CONTACT_EMAIL: process.env.NEXT_PUBLIC_CONTACT_EMAIL,
},
});
});
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,4 @@
"typescript": "^5.5.4",
"yaml": "^2.5.0"
}
}
}
Loading
Loading