added Twitter to connect #490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Indrajeety993648 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
|
@rithviknishad please review |
rithviknishad
requested changes
Aug 10, 2024
|
@rithviknishad One prettier related problem that is necessary to solve during commit that I changed . Rest are related to Issue , Please review and merge this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@rithviknishad please review . |
rithviknishad
requested changes
Aug 11, 2024
There was a problem hiding this comment.
Could you discard changes to the lockfile?
| NEXT_PUBLIC_GITHUB_URL: process.env.NEXT_PUBLIC_GITHUB_URL, | ||
| NEXT_PUBLIC_LINKEDIN_URL: process.env.NEXT_PUBLIC_LINKEDIN_URL, | ||
| NEXT_PUBLIC_YOUTUBE_URL: process.env.NEXT_PUBLIC_YOUTUBE_URL, | ||
| NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, // Add this line |
There was a problem hiding this comment.
Suggested change
| NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, // Add this line | |
| NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, |
| @@ -17,6 +17,7 @@ export const env = createEnv({ | |||
| NEXT_PUBLIC_GITHUB_URL: z.string(), | |||
| NEXT_PUBLIC_LINKEDIN_URL: z.string(), | |||
| NEXT_PUBLIC_YOUTUBE_URL: z.string(), | |||
| NEXT_PUBLIC_TWITTER_URL: z.string().optional(), // Add this line | |||
There was a problem hiding this comment.
Suggested change
| NEXT_PUBLIC_TWITTER_URL: z.string().optional(), // Add this line | |
| NEXT_PUBLIC_TWITTER_URL: z.string().optional(), |
| {env.NEXT_PUBLIC_TWITTER_URL && ( | ||
| <SocialLink | ||
| href={env.NEXT_PUBLIC_TWITTER_URL} | ||
| icon={FaTwitter} |
There was a problem hiding this comment.
You should be using the Twitter's X logo instead
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Twitter Support to Footer
Issue Fixes : #480
Description
This pull request introduces support for displaying a Twitter link in the footer component of the application. The following changes have been made:
Updated
Footer.tsxComponent:Connectsection.NEXT_PUBLIC_TWITTER_URLin the environment variables.Updated Environment Configuration (
env.mjs):NEXT_PUBLIC_TWITTER_URLto handle the optional Twitter URL.Fixed Formatting and Style Issues:
Changes
Footer.tsxConnectsection.env.mjsNEXT_PUBLIC_TWITTER_URLin the environment configuration.Checklist
Testing Instructions
.envfile includes theNEXT_PUBLIC_TWITTER_URLvariable.