Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNS: filter by locations changes #8812

Merged

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 17, 2024

Proposed Changes

image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 53bf95f
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6718fd169c34540008f47d64
😎 Deploy Preview https://deploy-preview-8812--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jacobjeevan
Copy link
Contributor Author

Jacobjeevan commented Oct 17, 2024

So we do need to make an extra change, consider the following scenario:

  • There are two locations (one with monitors with patients, one for monitors without).
image image

Now, consider following behavior.

(1) User selects "Include monitors without patients"
(2) Filters for location "Camera Locations" (which is only available under monitors without patients)
(3) User unchecks monitors without patients

At present, the filter form selection stays the same (resulting in No vitals screen, which is not accurate), so we need to reset the location selection whenever user marks/unmarks the checkbox.

@rithviknishad I'm wondering if there's a way to do that without touching LocationSelect?

@Jacobjeevan Jacobjeevan added the question Further information is requested label Oct 17, 2024
@Jacobjeevan Jacobjeevan marked this pull request as ready for review October 17, 2024 12:59
@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 17, 2024 12:59
@Jacobjeevan Jacobjeevan added needs testing needs review and removed question Further information is requested labels Oct 21, 2024
@Jacobjeevan
Copy link
Contributor Author

So we do need to make an extra change, consider the following scenario:

* There are two locations (one with monitors with patients, one for monitors without).
image
* When checkbox is unchecked, only one option shows up ("Dummy Locations"), which results in Filter by Location being disabled (as per the issue [In CNS page: filter by location- hide locations with no Monitors #8162](https://github.com/ohcnetwork/care_fe/issues/8162)).
image

Now, consider following behavior.

(1) User selects "Include monitors without patients" (2) Filters for location "Camera Locations" (which is only available under monitors without patients) (3) User unchecks monitors without patients

At present, the filter form selection stays the same (resulting in No vitals screen, which is not accurate), so we need to reset the location selection whenever user marks/unmarks the checkbox.

@rithviknishad I'm wondering if there's a way to do that without touching LocationSelect?

Resolved 👍

@rithviknishad rithviknishad removed their assignment Oct 21, 2024
@nihal467
Copy link
Member

LGTM

@nihal467 nihal467 added tested waiting for backend reviewed reviewed by a core member and removed needs testing labels Oct 21, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 23, 2024
Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Jacobjeevan Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 23, 2024
@bodhish bodhish merged commit 594c0d8 into ohcnetwork:develop Oct 23, 2024
22 checks passed
Copy link

@Jacobjeevan Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

noufalrahim pushed a commit to noufalrahim/care_fe that referenced this pull request Oct 24, 2024
@Jacobjeevan Jacobjeevan deleted the issues/8162-CNS-filter-modifications branch November 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In CNS page: filter by location- hide locations with no Monitors
4 participants