Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset location route: modifications for CNS #2545

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 17, 2024

Proposed Changes

  • Added a boolean filter to asset location route (used by Location dropdown)
    • Query parameter to filter for locations with/without consultation beds
  • For CNS, fetch only location with registered monitors

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

- Add a parameter to filter for locations with no monitors
	- Also filter for monitors without paitents
@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 17, 2024 12:51
@Jacobjeevan Jacobjeevan marked this pull request as draft October 17, 2024 12:53
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.03%. Comparing base (3bd5e4e) to head (cde2220).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2545      +/-   ##
===========================================
+ Coverage    70.01%   70.03%   +0.02%     
===========================================
  Files          198      198              
  Lines        11664    11674      +10     
  Branches      1606     1607       +1     
===========================================
+ Hits          8166     8176      +10     
  Misses        3107     3107              
  Partials       391      391              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anroopak anroopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshhari vigneshhari merged commit 69c2b83 into ohcnetwork:develop Oct 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants