Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): add @nx/storybook/plugin to graph projects #23079

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 29, 2024

This PR adds @nx/storybook/plugin so we infer Storybook targets rather than have them explicit inproject.json files.

Note: Storybook is fixed to 7.5.3, because 7.6.0+ is creating package.json files whenever storybook dev is run. Getting some guidance from the Storybook team on how to handle this. Will create a follow-up PR if we dont' resolve it here.

@jaysoo jaysoo requested review from FrozenPandaz, vsavkin and a team as code owners April 29, 2024 18:36
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 29, 2024 8:31pm

Copy link

nx-cloud bot commented Apr 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 42e7ab7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants