chore(repo): add @nx/storybook/plugin to graph projects

nrwl · Apr 29, 2024 · 42e7ab7 · 42e7ab7
1 parent 4fd731f
commit 42e7ab7
Show file tree

Hide file tree

Showing 15 changed files with 1,635 additions and 588 deletions.
diff --git a/.gitignore b/.gitignore
@@ -55,3 +55,5 @@ out
 .npm/
 .profile
 .rustup/
+
+storybook-static
diff --git a/graph/client/project.json b/graph/client/project.json
@@ -83,31 +83,6 @@
  }
  },
  "defaultConfiguration": "dev"
- },
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/client/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "configDir": "graph/client/.storybook",
- "outputDir": "dist/storybook/graph-client"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
  }
  },
  "tags": []

diff --git a/graph/ui-code-block/.storybook/main.ts b/graph/ui-code-block/.storybook/main.ts
@@ -1,8 +1,16 @@
 /* eslint-disable @nx/enforce-module-boundaries */
 import type { StorybookConfig } from '@storybook/react-vite';
 import { mergeConfig } from 'vite';
+
+// Pointing directly to node_modules so we don't transpile from source and up with with an error.
+// e.g. Cannot find module '../../bin/run-executor.js'
+// Require stack:
+// - packages/nx/src/tasks-runner/utils.ts
+// - packages/nx/src/devkit-exports.ts
+// - packages/devkit/index.ts
+// - /packages/vite/plugins/nx-tsconfig-paths.plugin.ts
 // nx-ignore-next-line
-import { nxViteTsPaths } from '@nx/vite/plugins/nx-tsconfig-paths.plugin';
+import { nxViteTsPaths } from '../../../node_modules/@nx/vite/plugins/nx-tsconfig-paths.plugin';
 
 const config: StorybookConfig = {
  stories: ['../src/lib/**/*.stories.@(js|jsx|ts|tsx|mdx)'],

diff --git a/graph/ui-code-block/project.json b/graph/ui-code-block/project.json
@@ -4,49 +4,5 @@
  "sourceRoot": "graph/ui-code-block/src",
  "projectType": "library",
  "tags": [],
- "targets": {
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/ui-code-block/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "outputDir": "dist/storybook/graph-ui-code-block",
- "configDir": "graph/ui-code-block/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "test-storybook": {
- "executor": "nx:run-commands",
- "options": {
- "command": "test-storybook -c graph/ui-code-block/.storybook --url=http://localhost:4400"
- }
- },
- "static-storybook": {
- "executor": "@nx/web:file-server",
- "options": {
- "buildTarget": "graph-ui-code-block:build-storybook",
- "staticFilePath": "dist/storybook/graph-ui-code-block"
- },
- "configurations": {
- "ci": {
- "buildTarget": "graph-ui-code-block:build-storybook:ci"
- }
- }
- }
- }
+ "targets": {}
 }
diff --git a/graph/ui-components/project.json b/graph/ui-components/project.json
@@ -4,31 +4,5 @@
  "sourceRoot": "graph/ui-components/src",
  "projectType": "library",
  "tags": [],
- "targets": {
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/ui-components/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "configDir": "graph/ui-components/.storybook",
- "outputDir": "dist/storybook/graph-ui-components"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- }
- }
+ "targets": {}
 }
diff --git a/graph/ui-graph/project.json b/graph/ui-graph/project.json
@@ -4,31 +4,5 @@
  "sourceRoot": "graph/ui-graph/src",
  "projectType": "library",
  "tags": [],
- "targets": {
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/ui-graph/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "configDir": "graph/ui-graph/.storybook",
- "outputDir": "dist/storybook/graph-ui-graph"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- }
- }
+ "targets": {}
 }
diff --git a/graph/ui-icons/.storybook/main.ts b/graph/ui-icons/.storybook/main.ts
@@ -1,8 +1,16 @@
 /* eslint-disable @nx/enforce-module-boundaries */
 import type { StorybookConfig } from '@storybook/react-vite';
 import { mergeConfig } from 'vite';
+
+// Pointing directly to node_modules so we don't transpile from source and up with with an error.
+// e.g. Cannot find module '../../bin/run-executor.js'
+// Require stack:
+// - packages/nx/src/tasks-runner/utils.ts
+// - packages/nx/src/devkit-exports.ts
+// - packages/devkit/index.ts
+// - /packages/vite/plugins/nx-tsconfig-paths.plugin.ts
 // nx-ignore-next-line
-import { nxViteTsPaths } from '@nx/vite/plugins/nx-tsconfig-paths.plugin';
+import { nxViteTsPaths } from '../../../node_modules/@nx/vite/plugins/nx-tsconfig-paths.plugin';
 
 const config: StorybookConfig = {
  stories: ['../src/lib/**/*.stories.@(js|jsx|ts|tsx|mdx)'],

diff --git a/graph/ui-icons/project.json b/graph/ui-icons/project.json
@@ -5,50 +5,5 @@
  "projectType": "library",
  "tags": [],
  "// targets": "to see all targets run: nx show project ui-icons --web",
- "targets": {
- "lint": {},
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/ui-icons/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "outputDir": "dist/storybook/graph-ui-icons",
- "configDir": "graph/ui-icons/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "test-storybook": {
- "executor": "nx:run-commands",
- "options": {
- "command": "test-storybook -c graph/ui-icons/.storybook --url=http://localhost:4400"
- }
- },
- "static-storybook": {
- "executor": "@nx/web:file-server",
- "options": {
- "buildTarget": "graph-ui-icons:build-storybook",
- "staticFilePath": "dist/storybook/graph-ui-icons"
- },
- "configurations": {
- "ci": {
- "buildTarget": "graph-ui-icons:build-storybook:ci"
- }
- }
- }
- }
+ "targets": {}
 }
diff --git a/graph/ui-project-details/.storybook/main.ts b/graph/ui-project-details/.storybook/main.ts
@@ -1,8 +1,15 @@
 /* eslint-disable @nx/enforce-module-boundaries */
 import type { StorybookConfig } from '@storybook/react-vite';
 
+// Pointing directly to node_modules so we don't transpile from source and up with with an error.
+// e.g. Cannot find module '../../bin/run-executor.js'
+// Require stack:
+// - packages/nx/src/tasks-runner/utils.ts
+// - packages/nx/src/devkit-exports.ts
+// - packages/devkit/index.ts
+// - /packages/vite/plugins/nx-tsconfig-paths.plugin.ts
 // nx-ignore-next-line
-import { nxViteTsPaths } from '@nx/vite/plugins/nx-tsconfig-paths.plugin';
+import { nxViteTsPaths } from '../../../node_modules/@nx/vite/plugins/nx-tsconfig-paths.plugin';
 import { mergeConfig } from 'vite';
 
 const config: StorybookConfig = {

diff --git a/graph/ui-project-details/project.json b/graph/ui-project-details/project.json
@@ -4,43 +4,5 @@
  "sourceRoot": "graph/ui-project-details/src",
  "projectType": "library",
  "tags": [],
- "targets": {
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/ui-project-details/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "outputDir": "dist/storybook/graph-ui-project-details",
- "configDir": "graph/ui-project-details/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "static-storybook": {
- "executor": "@nx/web:file-server",
- "options": {
- "buildTarget": "graph-ui-project-details:build-storybook",
- "staticFilePath": "dist/storybook/graph-ui-project-details"
- },
- "configurations": {
- "ci": {
- "buildTarget": "graph-ui-project-details:build-storybook:ci"
- }
- }
- }
- }
+ "targets": {}
 }
diff --git a/graph/ui-theme/project.json b/graph/ui-theme/project.json
@@ -4,31 +4,5 @@
  "sourceRoot": "graph/ui-theme/src",
  "projectType": "library",
  "tags": [],
- "targets": {
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/ui-theme/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "outputDir": "dist/storybook/ui-theme",
- "configDir": "graph/ui-theme/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- }
- }
+ "targets": {}
 }
diff --git a/graph/ui-tooltips/project.json b/graph/ui-tooltips/project.json
@@ -4,31 +4,5 @@
  "sourceRoot": "graph/ui-tooltips/src",
  "projectType": "library",
  "tags": [],
- "targets": {
- "storybook": {
- "executor": "@nx/storybook:storybook",
- "options": {
- "port": 4400,
- "configDir": "graph/ui-tooltips/.storybook"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- },
- "build-storybook": {
- "executor": "@nx/storybook:build",
- "outputs": ["{options.outputDir}"],
- "options": {
- "configDir": "graph/ui-tooltips/.storybook",
- "outputDir": "dist/storybook/graph-ui-tooltips"
- },
- "configurations": {
- "ci": {
- "quiet": true
- }
- }
- }
- }
+ "targets": {}
 }
diff --git a/nx.json b/nx.json
@@ -141,8 +141,7 @@
  "{workspaceRoot}/.storybook/**/*",
  "{projectRoot}/.storybook/**/*",
  "{projectRoot}/tsconfig.storybook.json"
- ],
- "cache": true
+ ]
  },
  "build-ng": {
  "cache": true
@@ -204,6 +203,15 @@
  "targetName": "e2e-local",
  "ciTargetName": "e2e-macos-ci"
  }
+ },
+ {
+ "plugin": "@nx/storybook/plugin",
+ "options": {
+ "serveStorybookTargetName": "storybook",
+ "buildStorybookTargetName": "build-storybook",
+ "testStorybookTargetName": "test-storybook",
+ "staticStorybookTargetName": "static-storybook"
+ }
  }
  ],
  "nxCloudAccessToken": "YmZiOWQyNzctOThiZC00MjYwLWI3YTAtZDA3MDg4YWY1YTExfHJlYWQ=",