Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed auto scroll not working when configure provider button is … #5282

Open
wants to merge 6 commits into
base: next
Choose a base branch
from
+3 −1
Open

fix: Fixed auto scroll not working when configure provider button is … #5282

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8baef89
fix: Fixed auto scroll not working when configure provider button is …
AdityaGos Mar 8, 2024
438f898
Merge branch 'next' of https://github.com/AdityaGos/novu into fix/aut…
AdityaGos Mar 8, 2024
4830757
Merge branch 'novuhq:next' into fix/auto-scroll-for-provider
AdityaGos Mar 15, 2024
bae0810
fix: Added dependency in the useEffect dependency array
AdityaGos Mar 15, 2024
f5f632e
Merge branch 'next' into fix/auto-scroll-for-provider
LetItRock Mar 18, 2024
16c4bb9
Merge branch 'next' into fix/auto-scroll-for-provider
AdityaGos Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/web/src/pages/integrations/components/multi-provider/SelectProviderSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,10 @@ export function SelectProviderSidebar({
};

useEffect(() => {
onTabChange(scrollTo?.toString());
}, [onTabChange, scrollTo]);
setTimeout(() => {
onTabChange(scrollTo?.toString());
}, 100);
}, []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there will be an ESLint warning about missing deps, please fix it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @LetItRock ,Just added the dependency . Was just curios about why we are putting onTabChange function as deps , we are scrolling once we land to the page .After that any tab changes , the onTabChange function will trigger the scrolling .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's safe to put the onTabChange here in the deps array, because it's memoized and won't change during the re-renders ;)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it 👍


return (
<Sidebar
Expand Down