fix: Fixed auto scroll not working when configure provider button is … #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
…o-scroll-for-provider
LetItRock
reviewed
Mar 15, 2024
| setTimeout(() => { | ||
| onTabChange(scrollTo?.toString()); | ||
| }, 100); | ||
| }, []); |
There was a problem hiding this comment.
there will be an ESLint warning about missing deps, please fix it
There was a problem hiding this comment.
Sure @LetItRock ,Just added the dependency . Was just curios about why we are putting onTabChange function as deps , we are scrolling once we land to the page .After that any tab changes , the onTabChange function will trigger the scrolling .
There was a problem hiding this comment.
it's safe to put the onTabChange here in the deps array, because it's memoized and won't change during the re-renders ;)
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5151
What change does this PR introduce?
This PR fixes auto scroll not working when we click on the configure providers button in Get Started Page
Why was this change needed?
Introduced a setTimeout to trigger the auto scroller correctly inside useEffect . Removed unnecessary element from dependency array of the useEffect.