Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VkNonDispatchableHandle uint64 and bring back vkPreload #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oakes
Copy link
Contributor

@oakes oakes commented Sep 17, 2021

Fixes nimgl/nimgl#70 and regenerates vulkan.nim, fixing the incorrect regeneration from this commit: 091ff99

@oakes oakes changed the title Make VkNonDispatchableHandle uint64 Make VkNonDispatchableHandle uint64 and bring back vkPreload Oct 15, 2021
@oakes
Copy link
Contributor Author

oakes commented Oct 15, 2021

@lmariscal this PR should fix this issue: nimgl/nimgl#72

The vulkan triangle test is currently broken because vkPreload (and other things) were removed in this commit: 091ff99

I'm guessing vulkan.nim was regenerated based on an old commit because those things re-appeared when I ran nimble gen again.

@oakes
Copy link
Contributor Author

oakes commented Oct 15, 2021

BTW, running nimble test still fails because i think it's using the release version of nimgl/vulkan, rather than the one from this repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VkNonDispatchableHandle should be an unsigned sixty-four bit integer, not a signed one
1 participant