Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VkNonDispatchableHandle should be an unsigned sixty-four bit integer, not a signed one #70

Open
zacharycarter opened this issue Sep 17, 2021 · 1 comment · May be fixed by nimgl/vulkan#5

Comments

@zacharycarter
Copy link

  • What is the current behaviour?
    Currently VkNonDispatchableHandle is defined as being a sixty-four bit integer

  • Please provide the steps to reproduce and if possible a minimal demo of the problem
    Look at vulkan.nim, line 42

  • What is the expected behaviour?
    According to vulkan_core.h, lines 53-59 it should be an unsigned sixty-four bit integer when pointers aren't being used for handles:

#ifndef VK_DEFINE_NON_DISPATCHABLE_HANDLE
    #if (VK_USE_64_BIT_PTR_DEFINES==1)
        #define VK_DEFINE_NON_DISPATCHABLE_HANDLE(object) typedef struct object##_T *object;
    #else
        #define VK_DEFINE_NON_DISPATCHABLE_HANDLE(object) typedef uint64_t object;
    #endif
#endif
  • Please tell us about your environment
    Not relevant

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, docs.gl, documentation etc)

The vulkan_core.h header makes this pretty clear that it should be a uint64 and not a int64

@oakes
Copy link
Contributor

oakes commented Sep 17, 2021

Fixed here nimgl/vulkan#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants