-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update npm dependencies #1771
Update npm dependencies #1771
Conversation
moved to thread |
package-lock.json
Outdated
@@ -7143,9 +7143,9 @@ | |||
"integrity": "sha512-gQutuDHPKNxUEcQ4pypZT4Wmrbapus+P9s3bR/SEOLsMbNqNoXigGImITygI5zhb+aA5rzflM6O8YWkmRbGkPA==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @m-akinc @jattasNI
FAST released the changes from microsoft/fast#6667 and microsoft/fast#6879 which this PR will update from @microsoft/[email protected]
After merged we should:
- Validate the following theme provider bug is fixed in nimble: Overriding theme with nested nimble-theme-provider doesn't work in all cases #1661
- Remove workarounds added for that theme provider bug in SystemLinkShared (@mollykreis do you know what needs to be updated?)
- Once validated we can close out the FAST issue: fix: Design token inherits value when it shouldn't microsoft/fast#6864
- Remove the following workaround from nimble: https://github.com/ni/nimble/blob/main/packages/nimble-components/src/anchor-menu-item/index.ts#L107-L122
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove workarounds added for that theme provider bug in SystemLinkShared (@mollykreis do you know what needs to be updated?)
The workaround that needs to be removed is in the Security UI. It got added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do all these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikisekarNI your listed as CODEOWNER for rich-text components. FYI the latest patch updates of tiptap dependencies in this PR are causing rich-text test failures and need to be addressed to unblock this work.
Edit: Also looks like the chromatic tests are finding a regression in behavior on bold and italics. Seems to not render a space anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we could split out the fast-foundation updates from this PR but it would be nice if the test failures from rich text were addressed. Also the tests may be catching behaviors that apps may find if they update their dependencies to latest which wouuld pull in the same tiptap updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-akinc not sure what your bandwidth looks like but lets not block the fast-foundation updates and associated clean-up and validation on rich text issues. Bumping the foundation version can be done in a separate PR if you have the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Captured the remaining checklist as acceptance criteria in #1661
d8e3ca4
to
7528175
Compare
d150f96
to
ad7ec83
Compare
4b7c3e4
to
2f8360f
Compare
# Pull Request ## 🤨 Rationale 1. Update all the Tiptap extensions to the latest version and fixes the build error from #1771 2. [Bug 2651659](https://dev.azure.com/ni/DevCentral/_workitems/edit/2651659): Comments acceptance tests failing in latest nimble/sl-comments-lib update The linked tests might fail because of the package update with the [deprecated method](https://github.com/ueberdosis/tiptap/blob/3e440c2f96cd56683d3d7eb3c0e6cea83f7a31b7/packages/extension-mention/src/mention.ts#L8C3-L9C86) used here for the mention-extesion. Here is the error from the console log: `ERROR TypeError: this.options.renderLabel is not a function at Object.renderHTML (create-tiptap-editor.ts:213:30)`. ## 👩💻 Implementation 1. Bump all the Tiptap versions to the latest `2.2.2` 2. Replaced the deprecated `renderLabel` method with the recommended `renderText` method for mention support. ## 🧪 Testing Manually verified the mention node rendering and other basic flows like adding an @mention and setting it via setMarkdown etc., ## ✅ Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed.
ff252e7
to
4db8921
Compare
4db8921
to
ab161ea
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Manual change notes:
This PR contains the following updates:
8.11.3
->8.11.8
3.0.1
->3.0.4
Release Notes
Microsoft/fast (@microsoft/fast-foundation)
v2.49.5
Compare Source
TanStack/table (@tanstack/table-core)
v8.11.8
Compare Source
Version 8.11.8 - 2/2/2024, 7:28 AM (Manual Release)
Changes
Docs
1bbac0f
) by Asad Khan8f95203
) by Kevin Van Cottcd80c52
) by Kevin Van Cotte6e02a9
) by Lachlan CollinsCi
c944980
) by Lachlan CollinsPackages
v8.11.7
Compare Source
Version 8.11.7 - 1/20/2024, 9:08 PM
Changes
Fix
56369bc
) by Lachlan CollinsChore
4e182ec
) by Kevin Van Cotta9a7668
) by Kevin Van CottDocs
9941ef1
) by @lucascmelo4f08e53
) by Lachlan Collins6c3f6d8
) by Lachlan Collinsf61a022
) by Kevin Vandyd5f514a
) by Kevin Van Cott801ee96
) by Kevin Van CottPackages
v8.11.6
Compare Source
Version 8.11.6 - 1/12/2024, 12:07 AM
Changes
Fix
0c0a947
) by Kevin VandyPackages
v8.11.5
Compare Source
Version 8.11.5 - 1/11/2024, 11:54 PM
Changes
Fix
8b0022d
) by Kevin VandyPackages
v8.11.4
Compare Source
Version 8.11.4 - 1/11/2024, 5:30 PM
Changes
Fix
9aba3c0
) by Kevin Vandy8e106a9
) by Jareth57336fc
) by Lachlan CollinsChore
0899c33
) by Lachlan Collins86d6447
) by Lachlan Collinsfefe74f
) by Lachlan Collins5d615ab
) by Lachlan Collinsa990435
) by Lachlan CollinsDocs
6561267
) by Nathan Isaac8a14fa6
) by Kevin Vandyb327934
) by Kevin Van Cott80d92d6
) by HephaestianCi
@tanstack/config
(#5257) (43989f2
) by Lachlan CollinsPackages
tanstack/virtual (@tanstack/virtual-core)
v3.0.4
Compare Source
Version 3.0.4 - 2/2/2024, 4:13 PM
Changes
Fix
5bd44f6
) by Austin AstorgaPackages
v3.0.3
Compare Source
Version 3.0.3 - 2/2/2024, 3:55 PM
Changes
Fix
1a5a95c
) by Karol ŻelukDocs
c2886b2
) by Lachlan CollinsPackages
v3.0.2
Compare Source
Version 3.0.2 - 1/17/2024, 3:47 PM
Changes
Fix
942791b
) by @hdwattsDocs
0a73be9
) by @jonahallibone26dca7c
) by Stefan DühringPackages
Configuration
📅 Schedule: Branch creation - "monthly" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.