Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm dependencies #1771

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Update npm dependencies #1771

merged 5 commits into from
Feb 13, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 23, 2024

Manual change notes:

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@tanstack/table-core (source) 8.11.3 -> 8.11.8 age adoption passing confidence
@tanstack/virtual-core 3.0.1 -> 3.0.4 age adoption passing confidence

Release Notes

Microsoft/fast (@​microsoft/fast-foundation)

v2.49.5

Compare Source

TanStack/table (@​tanstack/table-core)

v8.11.8

Compare Source

Version 8.11.8 - 2/2/2024, 7:28 AM (Manual Release)

Changes

Docs
Ci
  • Update example dependencies when publishing (#​5322) (c944980) by Lachlan Collins

Packages

v8.11.7

Compare Source

Version 8.11.7 - 1/20/2024, 9:08 PM

Changes

Fix
  • Update package.json repository and homepage fields (#​5292) (56369bc) by Lachlan Collins
Chore
  • svelte types workaround and simplify bug report template (#​5280) (4e182ec) by Kevin Van Cott
  • upgrade example versions and deps (#​5278) (a9a7668) by Kevin Van Cott
Docs

Packages

v8.11.6

Compare Source

Version 8.11.6 - 1/12/2024, 12:07 AM

Changes

Fix
  • contextDocument scope for SSR bug (0c0a947) by Kevin Vandy

Packages

v8.11.5

Compare Source

Version 8.11.5 - 1/11/2024, 11:54 PM

Changes

Fix
  • potential ssr bug with column sizing document (8b0022d) by Kevin Vandy

Packages

v8.11.4

Compare Source

Version 8.11.4 - 1/11/2024, 5:30 PM

Changes

Fix
  • add optional document context for resize listeners prettier (9aba3c0) by Kevin Vandy
  • add optional document context for resize listeners (#​5003) (8e106a9) by Jareth
  • Correctly exit publish script (#​5262) (57336fc) by Lachlan Collins
Chore
  • Fix incorrect npm tag for previous version release (#​5265) (0899c33) by Lachlan Collins
  • Stricter tsconfig options (#​5264) (86d6447) by Lachlan Collins
  • Update to Rollup v4, Vite v5 (#​5260) (fefe74f) by Lachlan Collins
  • Update examples to use Vite v4 (#​5259) (5d615ab) by Lachlan Collins
  • Update select workspace dependencies (#​5258) (a990435) by Lachlan Collins
Docs
  • fix meta data example (#​5256) (6561267) by Nathan Isaac
  • fix feature guide links (8a14fa6) by Kevin Vandy
  • refactor guides section and new table instance guide (#​5254) (b327934) by Kevin Van Cott
  • add solid filters example (#​5252) (80d92d6) by Hephaestian
Ci
  • Use publish function from @tanstack/config (#​5257) (43989f2) by Lachlan Collins

Packages

tanstack/virtual (@​tanstack/virtual-core)

v3.0.4

Compare Source

Version 3.0.4 - 2/2/2024, 4:13 PM

Changes

Fix
  • calculate getTotalSize correctly when using multiple lanes (#​660) (5bd44f6) by Austin Astorga

Packages

v3.0.3

Compare Source

Version 3.0.3 - 2/2/2024, 3:55 PM

Changes

Fix
  • sort items by index in case they end in the same position (#​655) (1a5a95c) by Karol Żeluk
Docs
  • Re-organise for new docs layout (#​653) (c2886b2) by Lachlan Collins

Packages

v3.0.2

Compare Source

Version 3.0.2 - 1/17/2024, 3:47 PM

Changes
Fix
Docs
Packages

Configuration

📅 Schedule: Branch creation - "monthly" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested review from rajsite and jattasNI as code owners January 23, 2024 22:02
@rajsite
Copy link
Member

rajsite commented Jan 23, 2024

moved to thread

@@ -7143,9 +7143,9 @@
"integrity": "sha512-gQutuDHPKNxUEcQ4pypZT4Wmrbapus+P9s3bR/SEOLsMbNqNoXigGImITygI5zhb+aA5rzflM6O8YWkmRbGkPA=="
Copy link
Member

@rajsite rajsite Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @m-akinc @jattasNI
FAST released the changes from microsoft/fast#6667 and microsoft/fast#6879 which this PR will update from @microsoft/[email protected]

After merged we should:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove workarounds added for that theme provider bug in SystemLinkShared (@mollykreis do you know what needs to be updated?)

The workaround that needs to be removed is in the Security UI. It got added here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do all these.

Copy link
Member

@rajsite rajsite Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikisekarNI your listed as CODEOWNER for rich-text components. FYI the latest patch updates of tiptap dependencies in this PR are causing rich-text test failures and need to be addressed to unblock this work.

Edit: Also looks like the chromatic tests are finding a regression in behavior on bold and italics. Seems to not render a space anymore
image

Copy link
Member

@rajsite rajsite Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we could split out the fast-foundation updates from this PR but it would be nice if the test failures from rich text were addressed. Also the tests may be catching behaviors that apps may find if they update their dependencies to latest which wouuld pull in the same tiptap updates.

Copy link
Member

@rajsite rajsite Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-akinc not sure what your bandwidth looks like but lets not block the fast-foundation updates and associated clean-up and validation on rich text issues. Bumping the foundation version can be done in a separate PR if you have the time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captured the remaining checklist as acceptance criteria in #1661

@renovate renovate bot force-pushed the renovate/npm-dependencies branch from d8e3ca4 to 7528175 Compare January 25, 2024 02:43
@rajsite rajsite marked this pull request as draft January 25, 2024 03:50
@renovate renovate bot force-pushed the renovate/npm-dependencies branch 9 times, most recently from d150f96 to ad7ec83 Compare February 4, 2024 09:43
@renovate renovate bot force-pushed the renovate/npm-dependencies branch 2 times, most recently from 4b7c3e4 to 2f8360f Compare February 9, 2024 01:46
rajsite pushed a commit that referenced this pull request Feb 13, 2024
# Pull Request

## 🤨 Rationale

1. Update all the Tiptap extensions to the latest version and fixes the
build error from #1771
2. [Bug
2651659](https://dev.azure.com/ni/DevCentral/_workitems/edit/2651659):
Comments acceptance tests failing in latest nimble/sl-comments-lib
update
The linked tests might fail because of the package update with the
[deprecated
method](https://github.com/ueberdosis/tiptap/blob/3e440c2f96cd56683d3d7eb3c0e6cea83f7a31b7/packages/extension-mention/src/mention.ts#L8C3-L9C86)
used here for the mention-extesion. Here is the error from the console
log: `ERROR TypeError: this.options.renderLabel is not a function
    at Object.renderHTML (create-tiptap-editor.ts:213:30)`. 

## 👩‍💻 Implementation

1. Bump all the Tiptap versions to the latest `2.2.2`
2. Replaced the deprecated `renderLabel` method with the recommended
`renderText` method for mention support.

## 🧪 Testing

Manually verified the mention node rendering and other basic flows like
adding an @mention and setting it via setMarkdown etc.,

## ✅ Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
@renovate renovate bot force-pushed the renovate/npm-dependencies branch 2 times, most recently from ff252e7 to 4db8921 Compare February 13, 2024 20:23
@renovate renovate bot force-pushed the renovate/npm-dependencies branch from 4db8921 to ab161ea Compare February 13, 2024 21:24
@rajsite rajsite marked this pull request as ready for review February 13, 2024 21:39
@rajsite rajsite enabled auto-merge (squash) February 13, 2024 21:39
Copy link
Contributor Author

renovate bot commented Feb 13, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@rajsite rajsite disabled auto-merge February 13, 2024 21:40
@rajsite rajsite merged commit d925547 into main Feb 13, 2024
12 checks passed
@rajsite rajsite deleted the renovate/npm-dependencies branch February 13, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants