Rich text editor | Update dependency on Tiptap #1818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The linked tests might fail because of the package update with the deprecated method used here for the mention-extesion. Here is the error from the console log:
ERROR TypeError: this.options.renderLabel is not a function at Object.renderHTML (create-tiptap-editor.ts:213:30)
.👩💻 Implementation
2.2.2
renderLabel
method with the recommendedrenderText
method for mention support.🧪 Testing
Manually verified the mention node rendering and other basic flows like adding an @mention and setting it via setMarkdown etc.,
✅ Checklist