Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich text editor | Update dependency on Tiptap #1818

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

vivinkrishna-ni
Copy link
Contributor

Pull Request

🤨 Rationale

  1. Update all the Tiptap extensions to the latest version and fixes the build error from Update npm dependencies #1771
  2. Bug 2651659: Comments acceptance tests failing in latest nimble/sl-comments-lib update
    The linked tests might fail because of the package update with the deprecated method used here for the mention-extesion. Here is the error from the console log: ERROR TypeError: this.options.renderLabel is not a function at Object.renderHTML (create-tiptap-editor.ts:213:30).

👩‍💻 Implementation

  1. Bump all the Tiptap versions to the latest 2.2.2
  2. Replaced the deprecated renderLabel method with the recommended renderText method for mention support.

🧪 Testing

Manually verified the mention node rendering and other basic flows like adding an @mention and setting it via setMarkdown etc.,

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc marked this pull request as ready for review February 13, 2024 17:10
@rajsite rajsite merged commit 34efe55 into main Feb 13, 2024
12 checks passed
@rajsite rajsite deleted the users/vivin/fix-mention-issue branch February 13, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants