Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): macOS CI failing with python{3.7, 3.8, 3.9} #579

Merged
merged 2 commits into from
Nov 3, 2024
Merged

fix(ci): macOS CI failing with python{3.7, 3.8, 3.9} #579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
648b0c7
fix(ci): do not use matrix variables for OS-specific commands
wookayin Oct 31, 2024
a6175a4
fix(ci): macOS CI failing with python{3.7, 3.8, 3.9}
wookayin Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 38 additions & 25 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,24 +32,21 @@ jobs:
exclude:
- os: 'ubuntu-latest'
python-version: '3.7'
- os: 'macos-latest'
python-version: '3.7'
- os: 'macos-latest'
python-version: '3.8'
- os: 'macos-latest'
python-version: '3.9'
include:
- os: 'ubuntu-20.04'
python-version: '3.7'
NIGHTLY: nvim-linux64.tar.gz
NVIM_BIN_PATH: nvim-linux64/bin
EXTRACT: tar xzf
- os: 'ubuntu-latest'
NIGHTLY: nvim-linux64.tar.gz
NVIM_BIN_PATH: nvim-linux64/bin
EXTRACT: tar xzf
- os: 'macos-latest'
NIGHTLY: nvim-macos-x86_64.tar.gz
NVIM_BIN_PATH: nvim-macos-x86_64/bin
EXTRACT: tar xzf
- os: 'windows-latest'
NIGHTLY: nvim-win64.zip
NVIM_BIN_PATH: nvim-win64/bin
EXTRACT: unzip
- os: 'macos-12'
python-version: '3.7'
- os: 'macos-12'
python-version: '3.8'
- os: 'macos-12'
python-version: '3.9'

name: "test (python ${{ matrix.python-version }}, ${{ matrix.os }})"
runs-on: ${{ matrix.os }}
Expand All @@ -60,20 +57,36 @@ jobs:
cache: 'pip'
python-version: ${{ matrix.python-version }}

- name: update path (bash)
- name: install neovim (Linux/macOS)
if: runner.os != 'Windows'
run: echo "$(pwd)/${{ matrix.NVIM_BIN_PATH }}" >> $GITHUB_PATH
run: |
set -eu -o pipefail

- name: update path (windows)
if: runner.os == 'Windows'
run: echo "$(pwd)/${{ matrix.NVIM_BIN_PATH }}" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
if [[ "$RUNNER_OS" == "Linux" ]]; then
BASE="nvim-linux64"
elif [[ "$RUNNER_OS" == "macOS" ]]; then
BASE="nvim-macos-x86_64"
else
echo "$RUNNER_OS not supported"; exit 1;
fi

curl -LO "https://github.com/neovim/neovim/releases/download/nightly/${BASE}.tar.gz"
tar xzf "${BASE}.tar.gz"
echo "RUNNER_OS = $RUNNER_OS"
$BASE/bin/nvim --version

- name: install neovim
# update $PATH for later steps
echo "$(pwd)/$BASE/bin" >> $GITHUB_PATH

- name: install neovim (Windows)
if: runner.os == 'Windows'
run: |
curl -LO 'https://github.com/neovim/neovim/releases/download/nightly/${{ matrix.NIGHTLY }}'
${{ matrix.EXTRACT }} ${{ matrix.NIGHTLY }}
echo '${{ runner.os }}'
nvim --version
curl -LO "https://github.com/neovim/neovim/releases/download/nightly/nvim-win64.zip"
unzip nvim-win64.zip
nvim-win64/bin/nvim --version

# update $PATH for later steps
echo "$(pwd)/nvim-win64/bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append

- name: install dependencies
run: |
Expand Down
Loading