Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): macOS CI failing with python{3.7, 3.8, 3.9} #579

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

wookayin
Copy link
Member

@wookayin wookayin commented Oct 31, 2024

macos-latest now points to M1 runners (macos-14-arm64) which do not support python 3.7-3.9. For these versions, use macos-12 runner.

Note: please do not squash commits for this PR.

@wookayin wookayin changed the title fix: macOS CI failing with python{3.7, 3.8, 3.9} fix(ci): macOS CI failing with python{3.7, 3.8, 3.9} Oct 31, 2024
@wookayin wookayin added the ci label Oct 31, 2024
@wookayin wookayin force-pushed the ci-macos branch 3 times, most recently from bde7961 to 9056f76 Compare October 31, 2024 15:30
@wookayin
Copy link
Member Author

wookayin commented Oct 31, 2024

CI is green now, but let me do a little bit of cleanup later today.

@wookayin wookayin force-pushed the ci-macos branch 3 times, most recently from 567d424 to 886fd98 Compare October 31, 2024 16:41
The use of `matrix.NIGHTLY`, `matrix.EXTRACT`, etc. makes CI matrix
configuration difficult. Instead, let the shell script for the neovim
installation step take care of OS specializations.
Problem: macos-latest now points to M1 runners (macos-14-arm64) which do not
support python 3.7 - 3.9.

Solution: For these python versions, use the macos-12 (x86_64) runner.
@wookayin wookayin marked this pull request as ready for review November 1, 2024 01:26
@wookayin wookayin requested a review from justinmk November 1, 2024 01:26
@wookayin wookayin self-assigned this Nov 1, 2024
Copy link
Member

@justinmk justinmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@justinmk justinmk merged commit 503af55 into neovim:master Nov 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants