Split Deframer into FrameAccumulator and Router #2900
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| class CRCWrapper { | ||
| protected: | ||
| //! \brief constructor setting initial value | ||
| CRCWrapper(TokenType initial) : m_crc(initial) {} |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit. Warning
thomas-bc
added
the
Update Instructions Needed
There was a problem hiding this comment.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
| class CRCWrapper { | ||
| protected: | ||
| //! \brief constructor setting initial value | ||
| CRCWrapper(TokenType initial) : m_crc(initial) {} |
Check warning
Code scanning / CppCheck
Single-parameter constructors should be marked explicit.
This was
linked to
issues
Sep 30, 2024
thomas-bc
changed the title
|
Will fix #2073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Split up Deframer into 3 components:
UplinkRouter?)Using this new structure, adding in 2 new deframers for CCSDS SpacePacket and TM protocols.
Rationale
Better reusability and chaining of deframers, preliminary work for CCSDS integrations
TODO
!!! Unit tests, SDDs, update documentation
!!! UPDATE
fprime-util new --deployment