Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build uplink router #2765

Open
Tracked by #2763
thomas-bc opened this issue Jun 7, 2024 · 3 comments · May be fixed by #2900
Open
Tracked by #2763

Build uplink router #2765

thomas-bc opened this issue Jun 7, 2024 · 3 comments · May be fixed by #2900
Assignees
@thomas-bc
Labels
enhancement

Comments

@thomas-bc
Copy link
Collaborator

F´ Version
Affected Component Router

Feature Description

Following #2763, build a router that sits after the Deframer and routes F´ packets to either FileUplink or CommandDispatcher
@thomas-bc thomas-bc self-assigned this Jun 7, 2024
This was referenced Jun 7, 2024
Open
Closed
@LeStarch
Copy link
Collaborator

@thomas-bc done?

@thomas-bc
Copy link
Collaborator Author

@LeStarch the PR is open here: #2900

We should keep this issue open until we have merged that, which will require to add more tests to both components.

Also Josh had made the suggestion a while back that Router was quite a generic name. Thoughts on renaming to UplinkRouter, or any other suggestion?

@thomas-bc thomas-bc linked a pull request Sep 30, 2024 that will close this issue
Split Deframer into FrameAccumulator and Router #2900
Draft
@LeStarch
Copy link
Collaborator

UplinkRouter makes more sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas-bc thomas-bc

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split Deframer into FrameAccumulator and Router thomas-bc/fprime
2 participants
@LeStarch @thomas-bc