win32: fix maximize state with --border=no

[kasper93]

WS_POPUP windows cannot be maximized, so instead of forcing it with unavoidable side-effects, change the window style before maximizing to make it work correctly.

[kasper93]

@na-na-hi: What do you think we do something like this for --border=no? Not tested much, there is one thing when toggling title bar in runtime to fix, but the idea would be the same.

[na-na-hi]

This is viable in principle as long as the states are correctly updated on state change request from both mpv and windows side. But currently it doesn't work and the title bar is shown when the window is maximized.

Interestingly, there are some inconsistencies here between unmaximizing from mpv and windows side. If I unmaximize the window from windows side, window snapping works afterwards even though it doesn't normally with --border=no. Seems exploitable to make window snapping work with --border=no.

[kasper93]

This is viable in principle as long as the states are correctly updated on state change request from both mpv and windows side.

Yeah, this is already quite annoying for fullscreen and other states too.

Interestingly, there are some inconsistencies here between unmaximizing from mpv and windows side. If I unmaximize the window from windows side, window snapping works afterwards even though it doesn't normally with --border=no. Seems exploitable to make window snapping work with --border=no.

It is --border=yes --title-bar=no state or unmaximized window, that still is "maximized", that can happen, but is not valid state. Either way, I don't think it is usable.

[na-na-hi]

It is --border=yes --title-bar=no state or unmaximized window, that still is "maximized", that can happen, but is not valid state.

Really? In this state, windows thinks it's unmaximized (any maximized state that got stuck for some reason goes away when I drag the window), mpv thinks it's unmaximized, and there are no corner rounding or borders at all (so not --border=yes --title-bar=no). This seems to be the result of mpv setting an unexpected window style that works this way.

[kasper93]

IIRC it happens when you resize maximized WS_POPUP window. It doesn't unmaximize itself.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32

macOS

• mpv-macos-14-arm
• mpv-macos-13-intel
• mpv-macos-12-intel

[kasper93]

But currently it doesn't work and the title bar is shown when the window is maximized.

ah, it still depended on --title-bar while it shouldn't. Now it should work correctly.

[na-na-hi]

The current version still has the symptom I described earlier, which you said wasn't a valid state:

If I unmaximize the window from windows side, window snapping works afterwards even though it doesn't normally with --border=no.

[kasper93]

@na-na-hi: needed to update style in WM_SIZE to account for external changes. Should be fine now.

[na-na-hi]

Works.