Add Windows Support for Lazy Commit of page map #727
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjp41
force-pushed
the
lazy_commit_windows
branch
3 times, most recently
from
bfa2572 to
f9c0b8c
Compare
mjp41
changed the title
The Pagemap can potentially be accessed where there is no direct knowledge of the location. On platforms with lazy commit this can be handled by the OS faulting in a zero page. Here we modify the Windows PAL to add an exception handler that will commit pages in the read only range, i.e. the page map. We still require explicit notify_using to be able to modify the pagemap.
mjp41
force-pushed
the
lazy_commit_windows
branch
from
f9c0b8c to
6789b80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Pagemap can potentially be accessed where there is no direct
knowledge of the location. On platforms with lazy commit this can
be handled by the OS faulting in a zero page. Here we modify the
Windows PAL to add an exception handler that will commit pages
in the read only range, i.e. the page map. We still require explicit
notify_using to be able to modify the pagemap.
Stacked on top of #725