Remove dependencies from Singleton and FlagLock #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjp41
force-pushed
the
singleton
branch
2 times, most recently
from
a026643 to
6d78c8c
Compare
|
FYI, I want this to be able to use the Singleton inside the Pal. |
mjp41
changed the title
|
@davidchisnall tagging you because you originally design the layering of directories. I think this respects the original design but enables a couple of pieces to be used in the Pal. This is important for implementing #727 without having to duplicate code. |
SchrodingerZhu
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The singleton and flag lock cannot be used inside the Pal. As it was defined in
dsrather thands_core. This alters the structure to add a ds_aal that can be used from the Pal, but can also take a dependence on the aal.