Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TagPicker): add aria-disabled to expand button when disabled #33530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −0
Open

fix(TagPicker): add aria-disabled to expand button when disabled #33530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7084972
fix: add aria-disabled to expand button
smhigley Dec 30, 2024
13e8f35
change file
smhigley Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-tag-picker-81e8253d-652a-423d-bd38-2f4ee36719cb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
smhigley marked this conversation as resolved.
Show resolved Hide resolved
"type": "patch",
"comment": "fix: add aria-disabled to expand button when disabled",
"packageName": "@fluentui/react-tag-picker",
"email": "[email protected]",
"dependentChangeType": "patch"
}
14 changes: 14 additions & 0 deletions ...ges/react-components/react-tag-picker/library/src/components/TagPicker/TagPicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,18 @@ describe('TagPicker', () => {
const expandButton = getByRole('button');
expect(expandButton.getAttribute('aria-labelledby')).toContain('Selected Employees');
});

it('sets expand button to disabled when TagPicker is disabled', () => {
const { getByRole } = render(
<TagPicker disabled>
<TagPickerControl>
<TagPickerInput />
</TagPickerControl>
<TagPickerList />
</TagPicker>,
);

const expandButton = getByRole('button');
expect(expandButton.getAttribute('aria-disabled')).toEqual('true');
});
});
1 change: 1 addition & 0 deletions ...mponents/react-tag-picker/library/src/components/TagPickerControl/useTagPickerControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export const useTagPickerControl_unstable = (
renderByDefault: !noPopover,
defaultProps: {
'aria-expanded': open,
'aria-disabled': disabled ? 'true' : undefined,
children: <ChevronDownRegular />,
role: 'button',
},
Expand Down
Loading