Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TagPicker): add aria-disabled to expand button when disabled #33530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smhigley
Copy link
Contributor

Previous Behavior

The expand button was the one holdout control that didn't get semantically disabled when the control is disabled

New Behavior

Adds aria-disabled! (the functionality is already handled, only the semantics were missing)

Related Issue(s)

@smhigley smhigley requested a review from a team as a code owner December 30, 2024 23:43
Copy link

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.158 MB
289.53 kB
1.158 MB
289.541 kB
32 B
11 B
react-tag-picker
@fluentui/react-tag-picker - package
185.227 kB
55.684 kB
185.259 kB
55.692 kB
32 B
8 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
222.703 kB
64.42 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.525 kB
36.087 kB
🤖 This report was generated against d61ac31da90bf8f73f54262e196b3a83b9a85932

Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants