-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tolerance for empty choices #4311
Open
MohMaz
wants to merge
12
commits into
microsoft:main
Choose a base branch
from
MohMaz:fix-tolerate-empty-choices-in-create-stream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−0
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ef81ed0
add tolerance for empty choices
MohMaz f02b127
Merge branch 'main' into fix-tolerate-empty-choices-in-create-stream
rysweet ef53cfa
Merge branch 'main' into fix-tolerate-empty-choices-in-create-stream
MohMaz cd07bb6
address pr comments
MohMaz 7165644
Merge branch 'main' into fix-tolerate-empty-choices-in-create-stream
MohMaz d98ca5f
Update python/packages/autogen-ext/src/autogen_ext/models/_openai/_op…
MohMaz f79b565
Update python/packages/autogen-ext/src/autogen_ext/models/_openai/_op…
MohMaz 972c53d
Merge branch 'main' into fix-tolerate-empty-choices-in-create-stream
MohMaz 1e19223
address pr comments
MohMaz e517332
Merge branch 'main' into fix-tolerate-empty-choices-in-create-stream
MohMaz eac2113
Update python/packages/autogen-ext/src/autogen_ext/models/_openai/_op…
MohMaz 293d2c4
Merge branch 'main' into fix-tolerate-empty-choices-in-create-stream
MohMaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the chunks with no choices have other data set on other fields of the delta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see anything int the
chunk.__dict__
. In the consecutive chunks, the choices gets populated properly and has all the expected fields.This has been happening only for the first 1-2 chunks to me, not sure if it's reproducible to all models. I've tried
gpt-4o