add tolerance for empty choices #4311
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Mazraeh <[email protected]>
rysweet
reviewed
Nov 22, 2024
python/packages/autogen-ext/src/autogen_ext/models/_openai/_openai_client.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-ext/src/autogen_ext/models/_openai/_openai_client.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Mohammad Mazraeh <[email protected]>
jackgerrits
reviewed
Nov 22, 2024
python/packages/autogen-ext/src/autogen_ext/models/_openai/_openai_client.py
Outdated
Show resolved
Hide resolved
jackgerrits
reviewed
Nov 22, 2024
python/packages/autogen-ext/src/autogen_ext/models/_openai/_openai_client.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-ext/src/autogen_ext/models/_openai/_openai_client.py
Outdated
Show resolved
Hide resolved
| while True: | ||
| try: | ||
| chunk_future = asyncio.ensure_future(anext(stream)) | ||
| if cancellation_token is not None: | ||
| cancellation_token.link_future(chunk_future) | ||
| chunk = await chunk_future | ||
|
|
||
| # This is to address a bug in AzureOpenAIChatCompletionClient. OpenAIChatCompletionClient works fine. | ||
| # https://github.com/microsoft/autogen/issues/4213 | ||
| if len(chunk.choices) == 0: |
There was a problem hiding this comment.
Do the chunks with no choices have other data set on other fields of the delta?
There was a problem hiding this comment.
I can't see anything int the chunk.__dict__. In the consecutive chunks, the choices gets populated properly and has all the expected fields.
{'id': '', 'choices': [], 'created': 0, 'model': '', 'object': '', 'service_tier': None, 'system_fingerprint': None, 'usage': None}
This has been happening only for the first 1-2 chunks to me, not sure if it's reproducible to all models. I've tried gpt-4o
python/packages/autogen-ext/src/autogen_ext/models/_openai/_openai_client.py
Outdated
Show resolved
Hide resolved
…enai_client.py Co-authored-by: Jack Gerrits <[email protected]>
…enai_client.py Co-authored-by: Jack Gerrits <[email protected]>
Signed-off-by: Mohammad Mazraeh <[email protected]>
jackgerrits
reviewed
Nov 25, 2024
python/packages/autogen-ext/src/autogen_ext/models/_openai/_openai_client.py
Outdated
Show resolved
Hide resolved
…enai_client.py Co-authored-by: Jack Gerrits <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I encountered this issue only in
AzureOpenAIChatCompletionClient, adding some tolerance for emptychoices! Not a super clean fix ... just works to unblock updating streaming samples usingAzureOpenAIChatCompletionClientRelated issue number
closes #4213
Checks